Skip to content

emrg: open-source rant project match — single config.project value (drop dual-compat) - #821

Merged
argszero merged 1 commit into
masterfrom
feature/os-rant-single-project
Aug 17, 2026
Merged

emrg: open-source rant project match — single config.project value (drop dual-compat)#821
argszero merged 1 commit into
masterfrom
feature/os-rant-single-project

Conversation

@argszero

Copy link
Copy Markdown
Owner

Fix host rant 2026-08-17T14:17:03 — host decision: rant project matching must use the SINGLE value config.project, no dual-compat.

Background: PR #760/#816 introduced owner/repo dual-compat matching, but the host ruled it out — rants should carry the config.project value (e.g. aitokenpool), and scanning matches only that one value.

Changes (emrg/server/open_source_prompt.md 0.5 Rant scan):

  • Match rant project against exactly {{ task.project }} (config.project); owner/repo form ({{ owner }}/{{ repo }}) no longer matches
  • Explicit example: config.project=aitokenpoolproject: aitokenpool matches; project: argszero/aitokenpool does NOT match
  • Unmatched-rant hint retained: rants whose project starts with either form but didn't match are reported so the host can fix the project field — never silently skipped

Tests: test_scheduler.py open_source template test updated to assert the single-match rule renders ("does NOT match" present).

Note: this changes the template only — installed runtime (v0.2.42) picks it up on the host's next update.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 576: open_source 0.5 now matches the single config.project value, owner/repo explicitly non-matching, unmatched-hint kept; template test updated; CI test+test-windows green. Matches rant 2026-08-17T14:17:03.

@pm25coder

Copy link
Copy Markdown
Contributor

I tested this PR end-to-end (Windows, branch feature/os-rant-single-project):

  • tests/test_scheduler.py: 80 passed, including the updated test_open_source_template_renders_with_context — the rendered prompt contains "aitokenpool" (config.project value), the explicit "does NOT match" wording for the owner/repo form, and the "Unmatched-rant hint" block is retained.
  • Full suite: 809 passed, 60 skipped (869 collected) — count unchanged, as expected for assertion-only test edits.
  • Import check + emrg --help CLI both OK.

The single-value semantics are clearer than the dual-compat form: with config.project: aitokenpool a rant filed as project: argszero/aitokenpool no longer silently matches, and the "Unmatched-rant hint" keeps the host informed so they can correct the rant's project field. One small observation: the hint text still mentions the {{ owner }}/{{ repo }} form for detection purposes, which is consistent — it is explicitly framed as a hint, not a match rule, and the new "does NOT match" sentence makes that boundary unambiguous. No issues found from my side.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 577: re-verified diff (open_source_prompt.md single-match + test update); CI green, mergeable CLEAN; pm25coder Windows pass confirms. 2/3.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 578: 3rd consecutive approval (576/577/578). Re-verified: single-match semantics correct, tests green, CI pass, mergeable CLEAN. Merging.

@argszero
argszero merged commit 1975662 into master Aug 17, 2026
2 checks passed
@argszero
argszero deleted the feature/os-rant-single-project branch August 17, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants