CMake Fetch content#220
Merged
Merged
Conversation
0d57d20 to
17be6e4
Compare
713f3b0 to
8ff3a5b
Compare
added 3 commits
January 25, 2021 16:26
Includes using custom FindOpenGL for building the library since there is no way to ensure the FindOpenGL module available on the system is from required cmake version.
928b155 to
c168299
Compare
067a2f4 to
cab9e00
Compare
f4cdd47 to
3c0a7a6
Compare
Also added freeimage location status message in cmake Corrected ci badges in README also
3c0a7a6 to
7316468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
Current Behavior
Examples CMake file has OpenGL linking logic which isn't necessary if library transitive linking flags are set appropriately.
New Behavior
Examples CMake file doesn't call
find_package(OpenGL ...)Breaking Change(s)
No
Please check if the PR fulfills these requirements
[ ] Relevant Examples are added/modified[ ] Relevant Documentation has been added/updated