Skip to content

fix: templated missing namespace metadata - #78

Closed
RealAnna wants to merge 2 commits into
arttor:mainfrom
keptn:feat/add_namespace
Closed

fix: templated missing namespace metadata#78
RealAnna wants to merge 2 commits into
arttor:mainfrom
keptn:feat/add_namespace

Conversation

@RealAnna

Copy link
Copy Markdown
Contributor

No description provided.

@RealAnna
RealAnna marked this pull request as draft February 20, 2023 12:25
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
RealAnna marked this pull request as ready for review February 20, 2023 13:09
@arttor

arttor commented Feb 20, 2023

Copy link
Copy Markdown
Owner

Thanks for your contribution but i think there may be some misunderstanding. Namespaces were removed from templates on purpose. Helm will use default namespase or set namespace from helm install -n option.

It is better to open an issue where we can discuss future changes before working on implementation.

@RealAnna

Copy link
Copy Markdown
Contributor Author

Thanks for your contribution but i think there may be some misunderstanding. Namespaces were removed from templates on purpose. Helm will use default namespase or set namespace from helm install -n option.

It is better to open an issue where we can discuss future changes before working on implementation.

Hi @arttor thanks for your explanation! I did create an issue here with my motivations for namespace. About the other PRs we needed to implement a first working solution in our fork anyway, but I will make sure to generate issues for each topic linking the PRs!

@arttor

arttor commented Feb 20, 2023

Copy link
Copy Markdown
Owner

@RealAnna sorry i was i little bit overwhelmed and missed the issue. I suggest not adding namespaces to templates since it is supported by helm out of the box.

@RealAnna

Copy link
Copy Markdown
Contributor Author

@arttor sorry again for the spams PRs 😸 I'll make sure to document every issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants