Skip to content

Stabilize source scroll synchronization test - #18

Merged
ashtree74 merged 1 commit into
mainfrom
codex/stabilize-scroll-ci
Aug 12, 2026
Merged

Stabilize source scroll synchronization test#18
ashtree74 merged 1 commit into
mainfrom
codex/stabilize-scroll-ci

Conversation

@ashtree74

Copy link
Copy Markdown
Owner

Summary

  • derive the test scroll target from the laid-out text line instead of an arbitrary clip-view pixel
  • assert the exact synchronized logical line within layout tolerance
  • keep production behavior unchanged

Verification

  • affected test: 10 consecutive passes
  • swift test: 135 XCTest + 5 Swift Testing tests passed
  • python3 -m unittest discover -s site -p 'test_*.py': 9 passed\n- shell syntax and property-list validation passed\n\n## Why\n\nThe post-merge main run exposed a timing/layout-sensitive failure that had passed on the PR. This makes the test use the same geometry-backed scroll path as the existing wrapped-line synchronization test.\n\nSigned-off-by: Adam Jesionkiewicz adam@jesion.pl

Signed-off-by: Adam Jesionkiewicz <adam@jesion.pl>

@ashtree74 ashtree74 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review completed. No blocking findings.

The patch is test-only and replaces an arbitrary pixel scroll with a target derived from TextKit layout, matching the production synchronization coordinate model. The assertion is stronger (logical line 30 ±1), the affected test passed 10 consecutive runs, and the full local suites passed.

I cannot approve my own PR, so after required checks pass I will use the repository’s disclosed maintainer PR-only bypass for the one-approval rule.

@ashtree74
ashtree74 merged commit c1b3faf into main Aug 12, 2026
2 checks passed
@ashtree74
ashtree74 deleted the codex/stabilize-scroll-ci branch August 12, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant