Stabilize source scroll synchronization test - #18
Merged
Conversation
Signed-off-by: Adam Jesionkiewicz <adam@jesion.pl>
ashtree74
commented
Aug 12, 2026
ashtree74
left a comment
Owner
Author
There was a problem hiding this comment.
Self-review completed. No blocking findings.
The patch is test-only and replaces an arbitrary pixel scroll with a target derived from TextKit layout, matching the production synchronization coordinate model. The assertion is stronger (logical line 30 ±1), the affected test passed 10 consecutive runs, and the full local suites passed.
I cannot approve my own PR, so after required checks pass I will use the repository’s disclosed maintainer PR-only bypass for the one-approval rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
swift test: 135 XCTest + 5 Swift Testing tests passedpython3 -m unittest discover -s site -p 'test_*.py': 9 passed\n- shell syntax and property-list validation passed\n\n## Why\n\nThe post-mergemainrun exposed a timing/layout-sensitive failure that had passed on the PR. This makes the test use the same geometry-backed scroll path as the existing wrapped-line synchronization test.\n\nSigned-off-by: Adam Jesionkiewicz adam@jesion.pl