Skip to content

Add TieredPGO_InstrumentOnlyHotCode=0 to tier0 jobs#1765

Merged
sebastienros merged 1 commit into
aspnet:mainfrom
EgorBo:fix-tier0
Oct 31, 2022
Merged

Add TieredPGO_InstrumentOnlyHotCode=0 to tier0 jobs#1765
sebastienros merged 1 commit into
aspnet:mainfrom
EgorBo:fix-tier0

Conversation

@EgorBo

@EgorBo EgorBo commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

We recently merged dotnet/runtime#70941 to runtime
It means that pgo=tier0-instrumented job no longer measures instrumented code and TieredPGO_InstrumentOnlyHotCode=0 should be added to bring it back.

image

cc @sebastienros

@sebastienros
sebastienros merged commit 496944a into aspnet:main Oct 31, 2022
@sebastienros

Copy link
Copy Markdown
Member

Lesson: we should keep setting the values even when they are the default.

@EgorBo

EgorBo commented Oct 31, 2022

Copy link
Copy Markdown
Contributor Author

Yep, but in this case TieredPGO_InstrumentOnlyHotCode=0 is a new thing - it didn't exist previously 🙂

@EgorBo
EgorBo deleted the fix-tier0 branch October 31, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants