Former proxied methods in AbstractIterableAssert are final. Is this by Design?

[mattbertolini]

I noticed in this commit the protected xxxForProxy methods were removed as they don't seem to be needed anymore in future versions of AssertJ. For example the AbstractIterableAssert.contains() method is public final and delegated to the protected containsForProxy() method. This worked great as I could override the protected method to add functionality in assertj-eclipse-collections. Now that the protected methods are removed, the public methods have remained public final so I can't override them. Is that by design? I've been using overriding of these methods to build out eclipse collection support to keep very close compatibility with the core assertion lib. It's no problem if it is by design but I wanted to raise this in case it was not intentional. Thanks.

[joel-costigliola]

I removed these methods as we don't need them anymore for proxying, but I did not realize some of the methods calling them were final, I'm happy to reintroduce these methods (basically reverting the commit) but not naming them forProxy , maybe doXXX ?

[mattbertolini]

doXXX sounds great to me!