Narrow two stale backend_xfail markers in test_cosmicray.py - #996
Merged
Conversation
The markers for test_cosmicray_median_masked_column and test_cosmicray_gain_correct_uncertainty_namespace were function-level and covered all parametrisations, but only a subset still fail on array-api-strict: masked_array cases pass in test_cosmicray_median_masked_column because they never put data on device1, and gain_apply=False cases pass in test_cosmicray_gain_correct_uncertainty_namespace on all backends. Narrow the markers to only the parametrisations that still fail. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S36ZzAAVXVm32vuTdtCQME
mwcraig
force-pushed
the
narrow-cosmicray-xfails
branch
from
August 25, 2026 19:57
46cab77 to
b5e4b5b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 9 9
Lines 1780 1780
=======================================
Hits 1740 1740
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #971 (stale
backend_xfailmarkers).On
main6724c8e, strict test_cosmicray.py shows 5 xpassed (failing narrowly at the scope of parametrised function-level markers). After this change: 0 xpassed.The markers for
test_cosmicray_median_masked_columnandtest_cosmicray_gain_correct_uncertainty_namespacewere function-level and covered all parametrisations, but only a subset still fail on array-api-strict. In the former, masked_array cases pass because they never put data on device1. In the latter, gain_apply=False cases pass on all backends. Both markers are now narrowed to only the parametrisations that still fail.The #958 astroscrappy-reason correction listed in #971 section 2 was already done on main in
d33d7cf— no action needed for it.🤖 Generated with Claude Code
https://claude.ai/code/session_01S36ZzAAVXVm32vuTdtCQME