Use "zoom to fit" as default - #81
Conversation
# Conflicts: # lib/image-editor-view.coffee
|
Merge conflict resolved and ready for another 👀 /cc @BinaryMuse @ungb |
|
LGTM! This is unrelated to this PR I suppose, but when the zoom to fit button is "disabled", it still looks like a clickable button to me. This seems like the case before this pr too. /cc @BinaryMuse for review |
The blue should mean "it's active", but yeah, to be consistent, the "Auto" button should be blue too once you start using the -+ to zoom. Made a new issue about it: #118 |
|
@BinaryMuse do you have a few minutes to review this? |
|
Ok, now that @TimvdLippe approved, we can merge it. 😄 On a serious note, it shouldn't be too risky and we have still a few weeks to test on master before it moves to Beta. 🚢 |
|
It was the nicest way of saying: "oh yes please" without seeming to nag about reviewing time ;) |
|
Was this merged in? Running Atom |
|
@aioue The fix is in Atom 1.20 currently in beta. |

Description of the Change
Changes the default to automatically resize an image to fit the available space.
Alternate Designs
It could also be a config, but even then (another PR), "zoom to fit" is still the better default.
Benefits
Able to see the whole image without having to click buttons.
Possible Drawbacks
Changes the default and might upset some.
Applicable Issues
Closes #55