Skip to content

test: increase ref2vaWrapper cancellation test timeouts for full-suite load (#9055) - #9060

Merged
atomantic merged 1 commit into
mainfrom
claim/issue-9055
Sep 28, 2026
Merged

atomantic merged 1 commit into
mainfrom
claim/issue-9055

Conversation

@atomantic

Copy link
Copy Markdown
Owner

Summary

Fixed a load-sensitive flake in ref2vaWrapper.test.js by increasing only the startup-stage timeout from 5s to 10s. The test spawns child processes with three sequential vi.waitFor stages; under full-suite load (2500+ files), the first stage (waiting for the runtime pid file to be written) exceeds 5s due to CPU contention during Node cold start + wrapper initialization + fake-runtime spawn.

  • Increased first vi.waitFor timeout from 5s → 10s for startup under load
  • Kept other two timeouts at 5s to preserve the process-group-kill behavior test
  • Raised overall test timeout from 15s → 25s to provide headroom

Test plan

  • Runs the specific test file standalone: ✅ All 3 tests pass (1289ms for the fixed test)
  • Verified the timeout increase does not weaken the process cancellation assertion
  • Code review: No findings

Closes #9055

…e load (#9055)

The test spawns child processes with three sequential waitFor stages, each with 5s timeouts.
Under full-suite load (2500+ files), the first stage (waiting for the runtime pid file)
exceeds 5s because Node cold start + wrapper startup + fake-runtime spawn competes for CPU.
Increased only the first waitFor timeout from 5s to 10s for startup under load, kept others
at 5s to preserve the process-group-kill behavior test, and raised overall test timeout from
15s to 25s to provide headroom. This remains load-sensitive but deterministic.
@atomantic
atomantic merged commit 66769e5 into main Sep 28, 2026
9 checks passed
@atomantic
atomantic deleted the claim/issue-9055 branch September 28, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref2vaWrapper.test.js: cancellation test times out at 5s under full-suite load (suspected flake)

1 participant