PY: Generate primitive type extension fields and restore extension/modifierExtension - #107
Merged
Conversation
ryukzak
requested changes
Mar 17, 2026
Collaborator
There was a problem hiding this comment.
- Let's try to use https://pypi.org/project/pytest-snapshot/ to reduce the amount of test libs.
- Let's add to the test how we can get extension data from resources. Looks like
res._genderwill not work.
MikhailArtemyev
force-pushed
the
py-extension-support-test
branch
from
March 18, 2026 20:27
6a02036 to
9eaa649
Compare
MikhailArtemyev
force-pushed
the
py-extension-support-test
branch
from
March 26, 2026 15:00
f499905 to
3aa002c
Compare
MikhailArtemyev
force-pushed
the
py-extension-support-test
branch
from
March 30, 2026 12:16
4536695 to
b2b5497
Compare
ryukzak
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
primitiveTypeExtensionoption to the Python generator — when enabled, generates_fieldNamecompanion fields (typed asElement) for every primitive field, following the FHIR JSON representation for primitive extensionsElement | None(e.g.birth_date_extension: Element | None)PyList[Element | None] | None(e.g.given_extension: PyList[Element | None] | None)Elementwhen the type isn't already in scopeextensionandmodifierExtensionfields onDomainResourceandBackboneElement— previously suppressed viaignoreFieldsin the generation configtest_raw_extension.pyexample test (mirrorstypescript-r4/raw-extension.test.ts) covering:extension,modifierExtension)HumanName,PatientContact)_birthDate,_family,_givenwith sparse arrays)Before/After
Generated Python model — primitive fields now have
_companions:Usage: