chore: drop the dead pnpm lockfile the yarn-only toolchain never reads - #6
Merged
Conversation
The examples directory carries both a yarn.lock and a pnpm-lock.yaml. Only yarn is real: CI and publishing install with yarn --frozen-lockfile and nothing in the repo mentions pnpm. The pnpm file came in with the original fork import and was never regenerated, so it pins years-old dependency resolutions that security scanners keep flagging even though no install ever reads them. Removing it leaves the live yarn lockfile as the single source of truth for the examples.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- examples/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The examples directory carries two lockfiles. Only
examples/yarn.lockis live: CI runsyarn install --frozen-lockfilewithcache: yarn, and no file in the repo mentions pnpm (grep -ril pnpmoutsidenode_modulesmatches only the lockfile itself).examples/pnpm-lock.yamlarrived with the original fork import in a single commit and was never touched since, so it pins stale resolutions that account for 22 of the 62 open Dependabot alerts while no install ever reads it.Validation
Zero pnpm references remain in
ci.yml,publish.yml, theMakefile, or anywhere else outsidenode_modules. The examples' ownyarn.lockis untouched.