chore(deps): re-resolve the dev toolchain past its advisories - #7
Merged
Conversation
Security scanners flag sixteen dev-scope dependency lines in the root lockfile, all with patched releases available. Most were unreachable only because the lockfile froze mocha at a release that pins js-yaml, minimatch and serialize-javascript to exact versions; re-resolving mocha inside its declared ^10 range lifts those pins to ranges that admit the patches. serialize-javascript is the one line no 6.x patch covers, so a resolutions entry carries both consumers to 7.x; the suite passes under mocha --parallel, the only mode that loads it. None of this reaches consumers: the published build is plain tsc and every touched line sits under the dev toolchain. The browser bundle target fails to compile with the same nineteen node-builtin resolution errors before and after, so that pre-existing red is carried as found.
There was a problem hiding this comment.
Pull request overview
Refreshes the development toolchain to patched dependency versions.
Changes:
- Re-resolves Mocha and Webpack dependencies.
- Forces
serialize-javascript7.1.0 through Yarn resolutions.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Adds the security resolution. |
yarn.lock |
Records patched dev-tool dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sixteen dev-scope alerts on the root
yarn.lockall have patched releases, but the lockfile froze mocha at a release that pinsjs-yaml,minimatchandserialize-javascriptto exact versions, so a plain refresh could not reach most of them. Re-resolving mocha inside its declared^10range lifts those pins to ranges that admit the patches (js-yaml 4.3.1, minimatch 5.1.9, brace-expansion 1.1.18/2.1.4, braces 3.0.3, picomatch 2.3.2, webpack 5.109.2).serialize-javascripthas no patched 6.x, so aresolutionsentry carries both consumers (mocha, terser-webpack-plugin) to 7.1.0. Nothing here reaches consumers: the published build is plaintscand every touched line is dev toolchain.Validation
yarn install --frozen-lockfile,yarn run build, and the VM suite all pass with the same executed count as before the change (35 passing), including undermocha --parallel, the only mode that loads serialize-javascript.scripts/packaging.test.sh8/8 andscripts/release-notes.test.sh12/12.yarn run build-webfails with an identical nineteen node-builtin resolution errors on the old and new lockfile (node-rsa imports; CI does not run this target), a pre-existing red carried as found.