Skip to content

proposal to add windows support to the custom target functionality - #8

Merged
MarvinJWendt merged 8 commits into
atomicgo:mainfrom
Brookke:proposal-add-windows-support
Jun 4, 2022
Merged

proposal to add windows support to the custom target functionality#8
MarvinJWendt merged 8 commits into
atomicgo:mainfrom
Brookke:proposal-add-windows-support

Conversation

@Brookke

@Brookke Brookke commented Mar 16, 2022

Copy link
Copy Markdown

No description provided.

@MarvinJWendt

Copy link
Copy Markdown
Member

Hi @Brookke, I can't get this to run:

image

@Brookke

Brookke commented Apr 16, 2022

Copy link
Copy Markdown
Author

@MarvinJWendt I have made some changes, could you also share your "experimenting" code if you don't mind and I can test my side :)

@codecov

codecov Bot commented Apr 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #8 (d46366e) into main (b809a13) will decrease coverage by 15.73%.
The diff coverage is 1.35%.

@@             Coverage Diff             @@
##             main       #8       +/-   ##
===========================================
- Coverage   26.04%   10.30%   -15.74%     
===========================================
  Files           4        5        +1     
  Lines          96      165       +69     
===========================================
- Hits           25       17        -8     
- Misses         69      146       +77     
  Partials        2        2               
Impacted Files Coverage Δ
cursor.go 33.33% <ø> (-53.34%) ⬇️
cursor_test_linux.go 0.00% <0.00%> (ø)
utils.go 0.00% <ø> (ø)
cursor_windows.go 27.27% <16.66%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b809a13...d46366e. Read the comment docs.

@MarvinJWendt

Copy link
Copy Markdown
Member

Hi @Brookke, the experimenting code is actually not relevant. It was a simple hello world, but the code didn't compile 😅

@Brookke

Brookke commented Apr 18, 2022

Copy link
Copy Markdown
Author

Hi @Brookke, the experimenting code is actually not relevant. It was a simple hello world, but the code didn't compile 😅

Hopefully the code should compile now. I have done some testing on a windows vm and it seems to work. The test will fail as the underlying calls are different on windows.

@MarvinJWendt

Copy link
Copy Markdown
Member

Hi @Brookke, sorry for the long wait. I am currently looking into fixing the tests :)

@MarvinJWendt MarvinJWendt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR :)

@MarvinJWendt
MarvinJWendt merged commit 5b50ff4 into atomicgo:main Jun 4, 2022
@MarvinJWendt MarvinJWendt added the feature New feature or request label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants