fix: sonar config

[AndrewHanasiro]

Summary by CodeRabbit

• Chores

  • Consolidated code-quality scanning into the test execution phase.
  • Updated test output configuration naming for better compatibility.

• Tests

  • Test workflow now runs the full test suite (unit + end-to-end) during CI.
  • Added an automated browser installation step to support end-to-end tests.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Reorganizes the CI workflow by moving the SonarCloud scan from the Audit job into the Test job, adds Playwright browser installation in Test, changes test invocation to npm run test, and renames the Playwright JUnit environment variable in package.json from PLAYWRIGHT_JSON_OUTPUT_NAME to PLAYWRIGHT_JUNIT_OUTPUT_NAME.

Changes

Cohort / File(s)	Summary
CI workflow .github/workflows/continuous_integration.yml	Moves SonarCloud scan step from Audit to Test; adds an "Install Playwright Browsers" step in Test; changes test execution from npm run test:unit to npm run test; adjusts step ordering and removes SonarCloud step from Audit.
Test script package.json	Updates scripts.test to set PLAYWRIGHT_JUNIT_OUTPUT_NAME=results.xml (was PLAYWRIGHT_JSON_OUTPUT_NAME) when running Playwright e2e tests; overall test command remains npm run test:unit -- --run && ... npm run test:e2e -- --reporter=junit.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Focus review on CI step ordering and environment variable correctness.
• Check .github/workflows/continuous_integration.yml for correct job permissions and step dependencies.
• Verify package.json script change matches Playwright consumer expectations.

Possibly related PRs

• feat: update #14: Modifies CI workflow and Playwright/JUnit environment naming similarly; likely touches the same integration points.

Poem

🐇 I hopped through YAML and JSON lines,

Moved SonarCloud to better times.
Browsers installed, tests now run,
JUnit name fixed — tidy and fun.
Hooray — the pipeline's set to shine!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided; the required template sections (Proposal and Links) are entirely missing.	Add a comprehensive description following the template, including a proposal section explaining the changes and relevant links to issues or documentation.
Title check	❓ Inconclusive	The title 'fix: sonar config' is vague and does not clearly convey the main changes; the PR involves workflow restructuring, playwright configuration, and environment variable updates beyond just SonarCloud.	Use a more specific title that captures the primary change, such as 'refactor: move SonarCloud scan to test job and update Playwright config' or 'fix: update Playwright configuration and CI workflow'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch hotfix/junit

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 308cf55 and 3b7a309.

📒 Files selected for processing (1)

• .github/workflows/continuous_integration.yml (2 hunks)

🔇 Additional comments (2)

.github/workflows/continuous_integration.yml (2)

44-47: Verify npm run test includes both unit and E2E tests and Playwright is installed before execution.

The test command has changed from npm run test:unit to npm run test, and Playwright browsers are now installed beforehand. Ensure that:

1. The npm run test script in package.json includes both unit and E2E tests as intended (not just unit tests).
2. The Playwright browser installation timing is correct and the PLAYWRIGHT_JUNIT_OUTPUT_NAME environment variable is properly set in the test script.

To verify this, check that your package.json test script matches the expected command and that the environment variable name aligns with what Playwright expects.

---

48-52: Verify SonarCloud scan relocation and job dependency implications.

The SonarCloud scan has been moved from the Audit job to the Test job. This means the code quality scan now depends on tests passing first. Confirm:

1. The Audit job no longer contains a SonarCloud scan step (verify the removed lines).
2. No explicit job dependencies have been removed or need to be added (e.g., if the Build or other jobs depend on Audit completing first, they should still work as intended).
3. This reorganization aligns with your CI/CD strategy—scanning only after tests pass is typically ideal, but verify the intent.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}