fix: ave-record-1.0.0.schema.json's $id still pointed at ave.bawbel.io - #165
Merged
Merged
Conversation
Every other schema file's $id already reads aveproject.org (the org-move checklist's section 5.1 covered ave-record-1.1.0 and the others); this frozen v1.0.0 snapshot was missed. Flagged by ave-site's scripts/publish-schemas.js, which warns about it at every build without altering it -- publishing a copy of a wrong $id isn't this repo's problem to paper over. Also doubles as the end-to-end trigger for this session's real fix: aveproject/ave-site's Pages source was set to "Deploy from a branch" (legacy, zero-build static serving) racing against the actual deploy.yml Actions pipeline -- the legacy path was winning, silently re-serving whatever records.js happened to be committed to git regardless of what deploy.yml had just correctly rebuilt. Switched that repo's Pages source to "GitHub Actions" via the API; this PR, once merged, is the real verification that notify-ave-site.yml (push to schema/**) -> repository_dispatch -> ave-site's deploy.yml -> GitHub Pages actually lands live now, not just that each piece works in isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other schema file's `$id` already reads `aveproject.org` (org-move checklist §5.1 covered `ave-record-1.1.0` and the rest); this frozen v1.0.0 snapshot was missed. `aveproject/ave-site`'s `scripts/publish-schemas.js` warns about this on every build without altering it — publishing a copy of a wrong `$id` isn't that repo's problem to paper over, it belongs here.
This also serves as the real end-to-end verification for a bigger fix made this session: `ave-site`'s GitHub Pages source was set to "Deploy from a branch" (legacy, zero-build static serving), which was racing against — and usually beating — the actual `deploy.yml` Actions pipeline. The legacy path has no build step, so it kept re-serving whatever `records.js` happened to be literally committed to `ave-site`'s git history, regardless of what `deploy.yml` had just correctly rebuilt from this repo. Switched `ave-site`'s Pages source to "GitHub Actions" via the API. Once this PR merges, `notify-ave-site.yml`'s push-triggered dispatch → `ave-site`'s `deploy.yml` → GitHub Pages should land live for real, not just succeed in isolation — will confirm against the live domain once merged.
🤖 Generated with Claude Code