Support latest versions of react-dnd, and other fixes#38
Conversation
…t context API). Add getScrollContainer - optional parameter: a function that returns scrolling container (useful for complex custom scroll components). It recieves one argument: root node of wrapped mounted component. Add typings for Typescript Add sideEffects: false parameter to package.json to optimize Webpack4 bundles
|
@eaglus unfortunately, it doesn't look like this repo is being maintained any more 😞 |
|
Please merge this PR @nickclaw 👍 this would be great! |
|
Sorry! I no longer work at Azuqua so I don't have push access. |
Hi Nick! Can you ask them to merge this PR? Does anybody have access to this repository? |
|
Does anybody have access to this repository? Please merge this |
|
Hi @eaglus, we will take a look at the changes this week. At a minimum the package major version needs to be increased, and we will review further when time permits. |
|
@eaglus any chance of doing this mate so we can get this pushed through? |
|
|
Please merge this, |
1 similar comment
|
Please merge this, |
|
I'm sorry for the delay in getting this reviewed, our team has been busy with other commitments. At this point I cannot commit to a particular timeline for reviewing, merging, and publishing these changes; if you have time pressures of your own, you should consider maintaining your own fork instead. Spamming other Azuqua employees is not an effective way to request progress on PR reviews, especially when they are not members of the team that uses this library. |
Sorry for spamming, @maxcutler ... |
|
@azuqua-bot , @maxcutler |
|
|
||
| declare const defaultHorizontalStrength: StrengthFunction; | ||
| declare const defaultVerticalStrength: StrengthFunction; | ||
|
|
There was a problem hiding this comment.
Exports like createVerticalStrength are missing here and causing import errors. Would be nice to fix that too
@spotware/react-dnd-scrollzone/typings/index"' has no exported member 'createVerticalStrength'.
|
Hi, I was wondering if it would it be possible to move this repo to the |
|
Scrolling down on IOS 13 is broken in the older versions of react-dnd, so was forced to update it, So I also need this fix... 😄 |
|
Hi everyone, I'd suggest that if you need this work done that you fork this to the |
react-dnd-scrollzone don't work with react-dnd >= 4.0.0, because it uses new React context API (Provider/Consumer from React 16.3).
This PR add support latest versions of react-dnd, which uses new React context API, and still supports old
react-dnd version, which uses old-style context api.
Another changes:
Add getScrollContainer - optional parameter: a function that returns scrolling container (useful for complex custom scroll components). It recieves one argument: root node of wrapped mounted component.
Add typings for Typescript
Add sideEffects: false parameter to package.json to optimize Webpack4 bundles