Skip to content

Resolve remaining automated issue follow-ups#336

Merged
baixiangcpp merged 4 commits into
mainfrom
fix/remaining-open-issues-2026-07
Jul 16, 2026
Merged

Resolve remaining automated issue follow-ups#336
baixiangcpp merged 4 commits into
mainfrom
fix/remaining-open-issues-2026-07

Conversation

@baixiangcpp

Copy link
Copy Markdown
Owner

Summary

  • Stabilize the input-intent audit and reject ambiguous Playwright-only CLI modes.
  • Fix Command Palette, JSON Tree, and Pipeline privacy dialog focus workflows, including trap and disconnected-opener recovery.
  • Harden PWA install/update ownership, pre-hydration prompt capture, stale install state, fail-fast CI timeouts, and localized install guidance.
  • Complete the mobile workflow matrix, Pipeline section navigation, viewport-pressure coverage, and Android browser guidance.

Review fixes included

  • Share one one-shot beforeinstallprompt across layout and Install App surfaces.
  • Preserve the once-per-session prompt gate while clearing stale installed state.
  • Persist appinstalled before deferred React UI mounts.
  • Capture install events in the existing same-origin parser-blocking runtime bootstrap.
  • Restore JSON rename focus when the original keyed node is replaced.
  • Fail unknown or conflicting --*-only flags before starting Playwright.
  • Bound navigator.serviceWorker.ready and the dedicated PWA CI job.
  • Direct Firefox/Edge Android users to Chrome-specific installation steps.

Validation

  • Node 20.20.2, npm 10.9.8
  • Production high/critical audit passed; the known moderate Next/PostCSS advisory remains tracked in Track upstream fix for Next bundled PostCSS advisory #7.
  • ESLint passed with no warnings.
  • Vitest: 319 files, 1,723 passed, 3 skipped.
  • Coverage: 83.06% statements, 72.55% branches, 89.89% functions, 86.5% lines.
  • npm run validate, build:app, and build:post passed.
  • Full Playwright smoke, 14-route-width screenshots, and independent PWA smoke passed.
  • Lighthouse 13.4.0 accessibility reports scored 100 on Home, All Tools, JSON Formatter, Pipeline Builder, Trust Center, and Install App.

Remaining manual boundaries

Closes #325
Refs #260
Refs #262
Refs #263

@baixiangcpp

Copy link
Copy Markdown
Owner Author

@codex review

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying byteflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8fdf891
Status: ✅  Deploy successful!
Preview URL: https://30d75fd5.byteflow-c58.pages.dev
Branch Preview URL: https://fix-remaining-open-issues-20.byteflow-c58.pages.dev

View logs

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 8fdf891d7e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX][P2] Audit input and textarea sizing by tool intent instead of using one flat default

1 participant