Skip to content

Fix immediate mobile copy feedback (#262)#339

Merged
baixiangcpp merged 1 commit into
mainfrom
fix/issue-262-immediate-copy-feedback
Jul 17, 2026
Merged

Fix immediate mobile copy feedback (#262)#339
baixiangcpp merged 1 commit into
mainfrom
fix/issue-262-immediate-copy-feedback

Conversation

@baixiangcpp

Copy link
Copy Markdown
Owner

Summary

  • show immediate, accessible Copy feedback before the lazy Sonner toaster is ready
  • preserve clipboard user activation while providing a visible fallback when feedback loading fails
  • anchor Sonner and inline feedback to the mobile visual viewport
  • cover first-click timing, fallback lifecycle, accessibility announcements, and mobile viewport placement

Validation

  • npm run build:app
  • npm run test:e2e:mobile
  • npm run test:e2e:smoke
  • npm run build:post
  • npm run test:e2e:pwa
  • npm run lint
  • npm run check:route-width-inventory
  • focused component and guard tests
  • full Vitest: 1741 tests passed; the OG timing gate exceeded its 45s suite threshold once, then passed 3/3 in 14.78s when rerun alone
  • git diff --check

Refs #262

The issue remains open for the required physical Android Chrome and iPhone Safari soft-keyboard, rotation, browser-chrome, touch, and Pipeline acceptance checks.

@baixiangcpp

Copy link
Copy Markdown
Owner Author

@codex review

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying byteflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc5371a
Status: ✅  Deploy successful!
Preview URL: https://6a812dea.byteflow-c58.pages.dev
Branch Preview URL: https://fix-issue-262-immediate-copy.byteflow-c58.pages.dev

View logs

@baixiangcpp
baixiangcpp force-pushed the fix/issue-262-immediate-copy-feedback branch from b16ca44 to cf2472d Compare July 17, 2026 14:32
@baixiangcpp

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: cf2472d21e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@baixiangcpp
baixiangcpp force-pushed the fix/issue-262-immediate-copy-feedback branch from cf2472d to dc5371a Compare July 17, 2026 14:55
@baixiangcpp

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: dc5371a2a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@baixiangcpp
baixiangcpp merged commit e40f2e3 into main Jul 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant