Align tool action group semantics (#263)#341
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Deploying byteflow with
|
| Latest commit: |
cb8ab2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://69645812.byteflow-c58.pages.dev |
| Branch Preview URL: | https://fix-issue-263-action-group-s.byteflow-c58.pages.dev |
a3fe2c9 to
cb8ab2d
Compare
|
@codex review\n\nPlease re-review commit cb8ab2d. This update fixes the two NVDA findings from the previous preview: the mobile filter button now announces a complete active-filter count, and external-request state changes use separate persistent polite/assertive live regions to prevent duplicate announcements. Focused tests, the full 1,743-test suite, build, smoke E2E/Axe, TypeScript, ESLint, i18n, and i18n QA all pass locally. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Final verification for cb8ab2d is complete.\n\n- GitHub build, PWA, and Cloudflare Pages checks are green.\n- Codex re-reviewed cb8ab2d and reported no major issues.\n- Full local suite: 1,743 passed, 3 skipped; production build and smoke E2E/Axe passed.\n- Windows 11 + NVDA 2026.1.1 + Chrome 150 against the immutable preview https://69645812.byteflow-c58.pages.dev passed on the left display only (window bounds x=-1880..-380).\n- NVDA spoke \Show filters. Active filters: 1\ exactly once.\n- NVDA spoke the external-request Offline status exactly once.\n- No youtube.com, youtube-nocookie.com, youtu.be, or i.ytimg.com request was emitted during the offline check.\n\nThe isolated Chrome/NVDA processes were closed after verification. |
Summary
Validation
Refs #263
The issue remains open for physical Android TalkBack or iPhone VoiceOver coverage and the remaining full assistive-technology runbook evidence.