Skip to content

Align tool action group semantics (#263)#341

Merged
baixiangcpp merged 1 commit into
mainfrom
fix/issue-263-action-group-semantics
Jul 17, 2026
Merged

Align tool action group semantics (#263)#341
baixiangcpp merged 1 commit into
mainfrom
fix/issue-263-action-group-semantics

Conversation

@baixiangcpp

Copy link
Copy Markdown
Owner

Summary

  • align ToolActionBar ARIA semantics with its existing native Tab interaction model
  • expose the shared action container as a named group instead of an incomplete composite toolbar
  • keep every enabled action in ordinary DOM/Tab order
  • update representative page tests, focus-restoration coverage, guards, and accessibility QA docs

Validation

  • 10 focused test files, 75 tests
  • npm run check:types
  • targeted ESLint
  • real Chromium role, Tab stop, and ArrowRight behavior check
  • npm run build
  • npm run test:e2e:smoke
  • representative Axe serious/critical checks
  • git diff --check
  • independent code review: no findings

Refs #263

The issue remains open for physical Android TalkBack or iPhone VoiceOver coverage and the remaining full assistive-technology runbook evidence.

@baixiangcpp

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: a3fe2c987b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploying byteflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb8ab2d
Status: ✅  Deploy successful!
Preview URL: https://69645812.byteflow-c58.pages.dev
Branch Preview URL: https://fix-issue-263-action-group-s.byteflow-c58.pages.dev

View logs

@baixiangcpp
baixiangcpp force-pushed the fix/issue-263-action-group-semantics branch from a3fe2c9 to cb8ab2d Compare July 17, 2026 17:42
@baixiangcpp

Copy link
Copy Markdown
Owner Author

@codex review\n\nPlease re-review commit cb8ab2d. This update fixes the two NVDA findings from the previous preview: the mobile filter button now announces a complete active-filter count, and external-request state changes use separate persistent polite/assertive live regions to prevent duplicate announcements. Focused tests, the full 1,743-test suite, build, smoke E2E/Axe, TypeScript, ESLint, i18n, and i18n QA all pass locally.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: cb8ab2de52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@baixiangcpp

Copy link
Copy Markdown
Owner Author

Final verification for cb8ab2d is complete.\n\n- GitHub build, PWA, and Cloudflare Pages checks are green.\n- Codex re-reviewed cb8ab2d and reported no major issues.\n- Full local suite: 1,743 passed, 3 skipped; production build and smoke E2E/Axe passed.\n- Windows 11 + NVDA 2026.1.1 + Chrome 150 against the immutable preview https://69645812.byteflow-c58.pages.dev passed on the left display only (window bounds x=-1880..-380).\n- NVDA spoke \Show filters. Active filters: 1\ exactly once.\n- NVDA spoke the external-request Offline status exactly once.\n- No youtube.com, youtube-nocookie.com, youtu.be, or i.ytimg.com request was emitted during the offline check.\n\nThe isolated Chrome/NVDA processes were closed after verification.

@baixiangcpp
baixiangcpp merged commit 72b9096 into main Jul 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant