Repository navigation
Conversation
It appears that the ninja Python package is legitimate and officially linked to both ninja-build and Meson. Therefore, adding ninja this way should make installing both Bfrescox packages much simpler for users. I confirmed that none of our actions are presently installing ninja manually. I suspect that the actions didn't have any issues without this explicit dependence because I believe that ninja is installed by default in their runners. This was working with tox locally after I removed ninja from my homebrew installation. It also works in a fresh venv build, which was failing before the dependence was added.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 58.75% 58.75%
=======================================
Files 17 17
Lines 320 320
=======================================
Hits 188 188
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Docs built successfully with tox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Self-review
ninjapackage name is spelled correctly and refers to that correct PyPI packageninjaandmesonare being installed for tasks that install their packagemesonnorninjais installed alongsidebfrescoxorbfrescoxproin their venvs.ninjais not installed in system. For each package, build clean venv, install package, confirm automatic installation ofninja, and confirm successful installation.mesonnorninjais installed alongsidebfrescoxorbfrescoxproin their venvs.