refactor(registrar): simplify registration manager dedupe - #3502
Merged
Conversation
Co-authored-by: Codex <codex-noreply@coinbase.com>
Collaborator
✅ Heimdall Review Status
|
jackchuma
marked this pull request as ready for review
June 12, 2026 18:48
jackchuma
enabled auto-merge
June 12, 2026 18:48
Co-authored-by: Codex <codex-noreply@coinbase.com>
Contributor
Review SummaryNo issues found. This is a clean refactor that correctly removes redundant deduplication from What was removed:
Why it's safe: The removed mutex was defence-in-depth. The driver's The updated doc comments accurately describe the new deduplication invariants. |
Contributor
✅ base-std fork tests: all 616 passedbase/base is fully in sync with the base-std spec.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
RegistrationManager no longer owns a process-local in-flight signer set; it now focuses on the single-signer registration path: checking whether the signer still needs registration, generating or recovering the proof, and handing the result to ProofHandler.
This also removes the old in-flight guard export and updates the registrar driver glue that constructed RegistrationManager.
Notes to reviewers
Task-level deduplication remains owned by the registrar driver pending task tracking.
How has it been tested?