Skip to content

Fix piped installer under nounset #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 2 commits into from
Jul 27, 2026
Merged

Fix piped installer under nounset #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc145ee
Fix piped installer under nounset
pradhankukiran Jul 27, 2026
0f3b638
Use current Bash in installer regression test
pradhankukiran Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions e2e/installer.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,15 @@ run_post_install_setup() {
[[ "$output" != *"Basecamp CLI"* ]] # banner would print if main ran
}

@test "install.sh runs main when piped to bash" {
# Keep PATH empty so main stops at its curl prerequisite without downloading
# anything or modifying the test environment.
run bash -c "cat '$INSTALL_SH' | PATH='$BATS_TEST_TMPDIR' '$BASH'"
[[ "$status" -ne 0 ]]
[[ "$output" == *"curl is required but not installed"* ]]
[[ "$output" != *"BASH_SOURCE[0]: unbound variable"* ]]
}

@test "new binary: post_install_setup dispatches to 'setup agents', never 'setup claude'" {
run_post_install_setup
[[ "$status" -eq 0 ]]
Expand Down
2 changes: 1 addition & 1 deletion scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,6 @@ post_install_setup() {
# Guard so sourcing the script (e.g. from tests) doesn't run the installer.
# The if-form is required: `[[ … ]] && main` returns 1 when sourced, which
# trips `set -e` in the sourcing shell.
if [[ "${BASH_SOURCE[0]}" == "$0" ]]; then
if [[ "${BASH_SOURCE[0]:-$0}" == "$0" ]]; then
main "$@"
fi