Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

Fix R18 erlang:now() deprecation warning - #49

Closed
mkurkov wants to merge 1 commit into
basho:developfrom
mkurkov:fix-r18-warnings
Closed

mkurkov wants to merge 1 commit into
basho:developfrom
mkurkov:fix-r18-warnings

Conversation

@mkurkov

@mkurkov mkurkov commented Aug 19, 2015

Copy link
Copy Markdown

HI, here is simple fix to remove R18 warning about deprecated erlang:now().

@hmmr

hmmr commented Aug 19, 2015

Copy link
Copy Markdown

+1

2 similar comments
@zyro

zyro commented Sep 8, 2015

Copy link
Copy Markdown

+1

@novabyte

novabyte commented Sep 8, 2015

Copy link
Copy Markdown

+1

@pichi

pichi commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

What is preventing pulling this request? It's half of year for two lines fix which effect doesn't escape from one function. It's ridiculous.

@hmmr

hmmr commented Feb 19, 2016

Copy link
Copy Markdown

@pichi Thanks for bumping this PR. There's no active development happening in erlang_js these days, and it keeps passing under radar while we are still stuck at OTP-16.

@mkurkov Can you rewrite it to use timer:tc/1, which seems to be a little more to the point? Like so:

{Elapsed, _ } = timer:tc(fun do_calls/2, [Ctx, Count]),
Elapsed / Count.

@pichi

pichi commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

@hmmr You are right. This is a way better solution.
See #55

@JeetKunDoug

Copy link
Copy Markdown

Will close this and get #55 merged. Thanks, and sorry for the delay in looking at the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants