feat: add setup opts, callbacks, persistent bookmarks, text search and menu UI - #6
Open
MadKuntilanak wants to merge 26 commits into
Open
MadKuntilanak wants to merge 26 commits into
MadKuntilanak wants to merge 26 commits into
Conversation
- Update README with new configuration options - Clarify `next_page`/`prev_page` keymaps are already set via opts.keymaps - Add Zathura installation instructions - Add example for `open.cb` callback (e.g. integrating with codecompanion.nvim) - Add example for statusline integration (e.g. heirline.nvim) - Remove `lines_per_page`
MadKuntilanak
force-pushed
the
feature/update_pdfview
branch
from
July 10, 2026 05:53
77e7455 to
66da9d4
Compare
Author
|
MadKuntilanak
marked this pull request as draft
July 13, 2026 22:29
MadKuntilanak
force-pushed
the
feature/update_pdfview
branch
from
July 14, 2026 21:01
ea910a0 to
94c6494
Compare
…tructure Bookmark storage is restructured from a flat list into a table with two fields: `items` (list of PDFviewBookmarkSavedData) and `__o` (per-pdf cached pages + mtime keyed by pdf_path). This allows pages to be reused across sessions without re-extracting text on every open. Renderer gains `state.o`,a per-pdf cache table populated by `update_state_o()` after every `display_text()` call. On subsequent opens, cached pages are passed directly to `display_text()` and mtime is checked against the current file; a mismatch triggers re-extraction. `get_mtime()` is added to utils for this purpose.
MadKuntilanak
force-pushed
the
feature/update_pdfview
branch
from
July 27, 2026 00:47
01ac1a3 to
602722c
Compare
go_to() now records jumps by default (skip_record now correctly used only for jumplist replay), fixing the previous behavior where go_to_page jumps were never recorded. add M.jumplist(step) for <C-i>/<C-o> navigation and M.select_jumplist() to pick a jump target directly via picker, keeping hist.pointer in sync with the selection
MadKuntilanak
marked this pull request as ready for review
August 8, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5
PDFview hasn't been updated in a while, so this PR brings it more in line with common Neovim plugin configuration conventions and adds several new features.
setup(opts)open.cb)go_tocommand for jumping to a specific pageshow_page_in_zathuracommandfzf-lua,telescope.nvim,and the defaultvim.ui.select(Telescope support still needs attention; see notes below)### Notes for the maintainer* Bookmark support for thetelescope.nvimpicker is not implemented yet. I'm not familiar enough with the Telescope picker API, as I primarily usefzf-lua.