Add changelog/unreleased-entry-required review rule#73
Merged
Conversation
There was a problem hiding this comment.
No worktree to remove — working directly in the checkout.
{
"verdict": "approve",
"summary": "PR adds a well-structured judgment rule `changelog/unreleased-entry-required` with clear `applies_when`, `enforcement`, `Why`, and examples. The PR dogfoods correctly by including its own `## Unreleased` bullet with `feat:` prefix. `rules/index.json` entry is valid JSON, all fields present. No issues found.",
"comments": [],
"concerns_addressed": [
"correctness: rule logic in docs/changelog-guide.md correctly gates on CHANGELOG.md presence and checks for a +bullet under ## Unreleased; waiver for comment/whitespace/guide-only diffs is well-reasoned",
"correctness: rules/index.json new entry is valid JSON with all required fields (id, anchor, applies_when, enforcement, enforcement_type, level, owner, trigger, doc_path)",
"correctness: CHANGELOG.md PR dogfoods correctly — ## Unreleased bullet added with feat: prefix, placed after preamble before ## v0.31.0"
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New review rule
changelog/unreleased-entry-required(SHOULD, judgment,@commitstrigger) added todocs/changelog-guide.md;rules/index.jsonregenerated viamake build-index.Flags any PR that changes non-vendored source in a repo that has a
CHANGELOG.mdbut adds no## Unreleasedbullet.SHOULD→ Should Fix →request-changes, so the maintainer bot won't auto-merge a PR that would leave the release agent nothing to promote.Why
In an
autoRelease: truerepo, the release agent renames## Unreleased→## vX.Y.Zpost-merge. A PR merged with an empty## Unreleasedmakes the release agent no-op — the change lands onmasterbut never ships to consumers. This rule is the forcing function that keeps every merge releasable.Coverage
One insertion point (rule index) feeds all three consumers:
/coding:pr-review,/coding:code-review, and the maintainer bot (its execution phase inlinespr-review.mdat runtime). No per-repo or bot-side change.Scope / detection
CHANGELOG.mdpresence at repo root (notautoRelease) — manual-release repos also need the section current.## Unreleasedentry.make precommitgreen (check-links, check-json, check-index, check-coverage 30/30, check-acceptance).