DEVSU-3011 Missing Canned Variant Text

[bnguyen-bcgsc]

• DEVSU-3011
• Update get_ipr_analyst_comments method with 'projects' key in queried variant-text being a list instead of single value (since projects and variant texts now have many-to-many relationship DEVSU-2864 Allow multiple projects to be associated with one variant-text item pori_ipr_api#499)
• Update project name matching logic to new projects data structure
• Update summary test to include integrated test to IPR API to validate mock IPR result schema with actual variant text schema from IPR

Requires IPR API PR: bcgsc/pori_ipr_api#516

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.84%. Comparing base (69f0e81) to head (6b27d1d).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
- Coverage    84.04%   83.84%   -0.20%     
===========================================
  Files           18       18              
  Lines         2613     2613              
===========================================
- Hits          2196     2191       -5     
- Misses         417      422       +5     

Flag	Coverage Δ
unittests	83.84% <100.00%> (-0.20%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mathieulemieux]

Fixing the unit tests is a good place to start but I was wondering why the integration tests didn't catch that bug in the first place. @elewis2, do you remember why we 'mock iprconn for ipr comments' ? 9ea52db
Was it a temporary mesure until the API gets updated, so now we can unmock it?

[mathieulemieux]

Just to keep track of things. As discussed about integration tests, maybe add a variant-text/schema route on the api side, then compare expected format with actual schema.

[elewis2]

Fixing the unit tests is a good place to start but I was wondering why the integration tests didn't catch that bug in the first place. @elewis2, do you remember why we 'mock iprconn for ipr comments' ? 9ea52db Was it a temporary mesure until the API gets updated, so now we can unmock it?

IMO the place an integration test would go would be in something like test_upload. But we haven't been running that from github iirc because it takes too long.