Bugfix/devsu 3023 make sync result format match async - #119
Merged
elewis2 merged 4 commits intoSep 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #119 +/- ##
===========================================
- Coverage 84.04% 84.01% -0.03%
===========================================
Files 18 18
Lines 2613 2615 +2
===========================================
+ Hits 2196 2197 +1
- Misses 417 418 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bnguyen-bcgsc
approved these changes
Sep 17, 2026
dustinbleile
approved these changes
Sep 18, 2026
dustinbleile
left a comment
Contributor
There was a problem hiding this comment.
branch worked for gsc_report tests
elewis2
deleted the
bugfix/DEVSU-3023-make-sync-result-format-match-async
branch
September 21, 2026 23:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes difference between object returned by ipr_report with async and non-async report uploading. Both upload types update the output object with the result of report submission to IPR-API but the async upload result includes the key 'report', which causes problems for gsc_reports. The sync upload result only includes keys 'ident' and 'message.'
This pr adds the 'ident' key to output for async report uploads and removes 'report'; 'message' is not available for this report creation type.