Skip to content

Bugfix/devsu 3023 make sync result format match async - #119

Merged
elewis2 merged 4 commits into
developfrom
bugfix/DEVSU-3023-make-sync-result-format-match-async
Sep 21, 2026
Merged

elewis2 merged 4 commits into
developfrom
bugfix/DEVSU-3023-make-sync-result-format-match-async

Conversation

@elewis2

@elewis2 elewis2 commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes difference between object returned by ipr_report with async and non-async report uploading. Both upload types update the output object with the result of report submission to IPR-API but the async upload result includes the key 'report', which causes problems for gsc_reports. The sync upload result only includes keys 'ident' and 'message.'
This pr adds the 'ident' key to output for async report uploads and removes 'report'; 'message' is not available for this report creation type.

@codecov-commenter

codecov-commenter commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.01%. Comparing base (7b2deb0) to head (ccda31f).

Files with missing lines Patch % Lines
pori_python/ipr/main.py 83.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #119      +/-   ##
===========================================
- Coverage    84.04%   84.01%   -0.03%     
===========================================
  Files           18       18              
  Lines         2613     2615       +2     
===========================================
+ Hits          2196     2197       +1     
- Misses         417      418       +1     
Flag Coverage Δ
unittests 84.01% <83.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dustinbleile dustinbleile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch worked for gsc_report tests

@elewis2
elewis2 merged commit 4d5dc45 into develop Sep 21, 2026
5 checks passed
@elewis2
elewis2 deleted the bugfix/DEVSU-3023-make-sync-result-format-match-async branch September 21, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants