Skip to content

fix: Use SliceStable to sort potential changes - #265

Merged
TimothyStiles merged 3 commits into
bebop:mainfrom
Jorropo:fix/sorting
Sep 12, 2022
Merged

fix: Use SliceStable to sort potential changes#265
TimothyStiles merged 3 commits into
bebop:mainfrom
Jorropo:fix/sorting

Conversation

@Jorropo

@Jorropo Jorropo commented Sep 12, 2022

Copy link
Copy Markdown
Contributor
$ go version
go version go1.19.1 linux/amd64
$ go test -run=ExampleCds .
ok  	github.com/TimothyStiles/poly/synthesis/fix	0.008s

Fixes golang/go#55009

@TimothyStiles

TimothyStiles commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

It would have taken me forever to figure this out! Thank you so much @Jorropo!

@TimothyStiles
TimothyStiles merged commit 59ce2fe into bebop:main Sep 12, 2022
@Koeng101

Copy link
Copy Markdown
Contributor

Thank you strange and wonderful internet person!

@Jorropo

Jorropo commented Sep 12, 2022

Copy link
Copy Markdown
Contributor Author

@TimothyStiles it took me 20 minutes, 10 of them was watching youtube while git bisect run was running.
git bisect is OP imo you should learn about it 🙂

@Jorropo
Jorropo deleted the fix/sorting branch September 12, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard to trace behavior change that causes tests to fail when bumping to Go 1.19 from Go 1.18

3 participants