Subscribe Form and Advertisement blocks bug fixes#146
Merged
Conversation
The beehiiv subscribe form preview did not render correctly with different form styles in the block editor. Replace the SandBox preview with a placeholder explaining the form only renders on the front-end, and remove the now-unused preview markup and styles.
An empty Advertisement block was silently dropped from the payload, so the newsletter sent without it as long as another supported block was present. Reject the send instead and tell the user to select an ad or remove the block. - Refuse the send server-side with a beehiiv_advertisement_no_ad error and editor-friendly copy - Show a proactive sidebar notice while "Send to newsletter" is on, suppressed once the server-side error is displayed to avoid duplicates
A selected advertisement stayed in the block dropdown as a normal option after it was unclaimed/removed in beehiiv, with no indication it was gone, letting a newsletter send with a reference to an ad that no longer exists. - Label the saved selection '— no longer available' in the dropdown when a successful load omits it, guarding on a load-success flag so a failed or empty error response never false-flags an ad as stale - Add a warning notice with a one-click 'Clear selection' action - Refuse the send server-side with a friendly error when an Advertisement block references an ad beehiiv no longer offers, enforced only on a confirmed API response so transient failures never block a valid send
zackaira
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.