Skip to content

Remove BDB version from the Information tab - #118

Merged
maflcko merged 1 commit into
bitcoin-core:masterfrom
hebasto:201027-bdb
Nov 18, 2020
Merged

Remove BDB version from the Information tab#118
maflcko merged 1 commit into
bitcoin-core:masterfrom
hebasto:201027-bdb

Conversation

@hebasto

@hebasto hebasto commented Oct 27, 2020

Copy link
Copy Markdown
Member

Master (67d4643):
DeepinScreenshot_select-area_20201027161350

This PR:
DeepinScreenshot_select-area_20201027161449

@jonasschnelli

Copy link
Copy Markdown
Contributor

Yeah. Why not.
Code Review ACK c61024c

@promag

promag commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Is this even useful in the GUI? Sounds like one of those things that a GUI user doesn't care about. Not even in the RPC console. I'd just remove it..

@achow101

Copy link
Copy Markdown
Member

Agree with @promag. It seems kind of useless to include this in the GUI.

@hebasto hebasto changed the title Hide BDB info when -disablewallet Remove BDB version from the Information tab Oct 28, 2020
@hebasto

hebasto commented Oct 28, 2020

Copy link
Copy Markdown
Member Author

@promag

Is this even useful in the GUI? Sounds like one of those things that a GUI user doesn't care about. Not even in the RPC console. I'd just remove it..

@achow101

Agree with @promag. It seems kind of useless to include this in the GUI.

BDB version string removed completely :)
Please re-review.

@promag

promag commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

We leave it in the console?

@hebasto

hebasto commented Oct 28, 2020

Copy link
Copy Markdown
Member Author

We leave it in the console?

Not sure if I understand right what do you mean.

@promag

promag commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Ah sorry @hebasto, forgot I was in another branch 🤦

@achow101

Copy link
Copy Markdown
Member

ACK e4fc45a

@jonasschnelli

Copy link
Copy Markdown
Contributor

Probably fine to remove it. I guess nobody is using this information.
utACK e4fc45a

@Sjors

Sjors commented Oct 30, 2020

Copy link
Copy Markdown
Member

utACK e4fc45a

This information can still be found in the debug log whenever you load a wallet.

@promag

promag commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

ACK e4fc45a.

@jarolrod jarolrod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK e4fc45a
Built and tested on Arch Linux (Kernel 5.18.5) and macOS 10.15.7

@jonasschnelli jonasschnelli added this to the 0.22.0 milestone Nov 11, 2020
@maflcko
maflcko merged commit 4ae0409 into bitcoin-core:master Nov 18, 2020
@hebasto
hebasto deleted the 201027-bdb branch November 18, 2020 10:47
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 18, 2020
apoelstra added a commit to apoelstra/elements that referenced this pull request Dec 3, 2020
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Mar 23, 2021
@jarolrod jarolrod mentioned this pull request Sep 22, 2021
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants