Skip to content

Avoid redundant redeclaration of GetWarnings(const string&) - #10864

Merged
jonasschnelli merged 1 commit into
bitcoin:masterfrom
practicalswift:GetWarnings-in-warnings.h
Jul 19, 2017
Merged

Avoid redundant redeclaration of GetWarnings(const string&)#10864
jonasschnelli merged 1 commit into
bitcoin:masterfrom
practicalswift:GetWarnings-in-warnings.h

Conversation

@practicalswift

Copy link
Copy Markdown
Contributor

Avoid redundant redeclaration of GetWarnings(const string&).

std::string GetWarnings(const std::string& strFor) is declared in warnings.h and defined in warnings.cpp.

Comment thread src/validation.h Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the documentation?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Thanks!

std::string GetWarnings(const std::string& strFor) is declared in
warnings.h and defined in warnings.cpp.
@practicalswift
practicalswift force-pushed the GetWarnings-in-warnings.h branch from 3a46c35 to e0d4592 Compare July 18, 2017 13:54
@TheBlueMatt

Copy link
Copy Markdown
Contributor

utACK e0d4592

@maflcko

maflcko commented Jul 18, 2017

Copy link
Copy Markdown
Member

utACK e0d4592

@sipa

sipa commented Jul 19, 2017

Copy link
Copy Markdown
Member

utACK e0d4592

@jonasschnelli

Copy link
Copy Markdown
Contributor

utACK e0d4592

@jonasschnelli
jonasschnelli merged commit e0d4592 into bitcoin:master Jul 19, 2017
jonasschnelli added a commit that referenced this pull request Jul 19, 2017
…ng&)

e0d4592 Avoid redundant redeclaration of GetWarnings(const string&) (practicalswift)

Pull request description:

  Avoid redundant redeclaration of `GetWarnings(const string&)`.

  `std::string GetWarnings(const std::string& strFor)` is declared in `warnings.h` and defined in `warnings.cpp`.

Tree-SHA512: d1503e00a2073cf080d66eafa303dc9c660a7ac15d4d2abcf2e4aa69cf9622d89a8e3f09324139bb7b8debaa6d1ee4a1c1681d347cebd99b1d3672a4da6d1ace
@jonasschnelli

Copy link
Copy Markdown
Contributor

Sorry. I accidentally merged this after the freeze.

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 24, 2019
…st string&)

e0d4592 Avoid redundant redeclaration of GetWarnings(const string&) (practicalswift)

Pull request description:

  Avoid redundant redeclaration of `GetWarnings(const string&)`.

  `std::string GetWarnings(const std::string& strFor)` is declared in `warnings.h` and defined in `warnings.cpp`.

Tree-SHA512: d1503e00a2073cf080d66eafa303dc9c660a7ac15d4d2abcf2e4aa69cf9622d89a8e3f09324139bb7b8debaa6d1ee4a1c1681d347cebd99b1d3672a4da6d1ace
@practicalswift
practicalswift deleted the GetWarnings-in-warnings.h branch April 10, 2021 19:32
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants