tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions by practicalswift · Pull Request #17071 · bitcoin/bitcoin

practicalswift · 2019-10-07T14:43:01Z

Add fuzzing harness for CheckBlock(...) and other CBlock related functions.

Testing this PR

Run:

$ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined
$ make
$ src/test/fuzz/block
…
# And to to quickly verify that the relevant code regions are triggered, that the
# fuzzing throughput seems reasonable, etc.
$ contrib/devtools/test_fuzzing_harnesses.sh '^block$'

test_fuzzing_harnesses.sh can be found in PR #17000.

maflcko

Concept ACK

DrahtBot · 2019-10-07T18:34:06Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17229 (tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions by practicalswift)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

practicalswift · 2019-10-24T21:28:10Z

Rebased! :)

practicalswift · 2019-10-31T14:14:15Z

Rebased and added a fuzzing harness for ContextualCheckBlock(…).

practicalswift · 2019-10-31T15:24:53Z

@MarcoFalke

~~When fuzzing BlockWitnessMerkleRoot(…) I noticed that leaves[0].SetNull() is done also in the case when leaves.empty() (due to block.vtx.empty()):~~

bitcoin/src/consensus/merkle.cpp

Lines 75 to 84 in d0f81a9

    
           uint256 BlockWitnessMerkleRoot(const CBlock& block, bool* mutated) 
        
           { 
        
               std::vector<uint256> leaves; 
        
               leaves.resize(block.vtx.size()); 
        
               leaves[0].SetNull(); // The witness hash of the coinbase is 0. 
        
               for (size_t s = 1; s < block.vtx.size(); s++) { 
        
                   leaves[s] = block.vtx[s]->GetWitnessHash(); 
        
               } 
        
               return ComputeMerkleRoot(std::move(leaves), mutated); 
        
           }

~~Makes sense to guard against this? :)~~

Update: Working around this by simply skipping the call to BlockWitnessMerkleRoot(…) in case of block.vtx.empty().

practicalswift · 2019-12-06T09:09:34Z

Rebased! :)

practicalswift · 2019-12-10T21:35:55Z

Should be ready for final review :)

maflcko · 2019-12-13T17:01:31Z

ACK c5d08da5c38e4140f4b9465f3e8159bcd7874ab2

…missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus

…ed functions

…r CBlock related functions 893aa20 tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions (practicalswift) ec8dcb0 tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus (practicalswift) Pull request description: Add fuzzing harness for `CheckBlock(...)` and other `CBlock` related functions. **Testing this PR** Run: ``` $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined $ make $ src/test/fuzz/block … # And to to quickly verify that the relevant code regions are triggered, that the # fuzzing throughput seems reasonable, etc. $ contrib/devtools/test_fuzzing_harnesses.sh '^block$' ``` `test_fuzzing_harnesses.sh` can be found in PR #17000. Top commit has no ACKs. Tree-SHA512: 275abd46d8ac970b28d8176f59124988b1e07c070173e001acd55995b830333417f301c309199fc589da08a6ac4c03aa74650d5e1638f6e3023dfbd3c9f6921d

…ed functions Summary: ``` Add fuzzing harness for CheckBlock(...) and other CBlock related functions. ``` Backport of core [[bitcoin/bitcoin#17071 | PR17071]]. The missing corpora change is not relevant for us. Test Plan: ninja bitcoin-fuzzers ./test/fuzz/test_runner.py <path_to_corpus> Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8151

…nd other CBlock related functions 893aa20 tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions (practicalswift) ec8dcb0 tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus (practicalswift) Pull request description: Add fuzzing harness for `CheckBlock(...)` and other `CBlock` related functions. **Testing this PR** Run: ``` $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined $ make $ src/test/fuzz/block … # And to to quickly verify that the relevant code regions are triggered, that the # fuzzing throughput seems reasonable, etc. $ contrib/devtools/test_fuzzing_harnesses.sh '^block$' ``` `test_fuzzing_harnesses.sh` can be found in PR bitcoin#17000. Top commit has no ACKs. Tree-SHA512: 275abd46d8ac970b28d8176f59124988b1e07c070173e001acd55995b830333417f301c309199fc589da08a6ac4c03aa74650d5e1638f6e3023dfbd3c9f6921d

merge bitcoin#17071...bitcoin#18206: fuzzing harness backports (part 1)

maflcko reviewed Oct 7, 2019

View reviewed changes

Comment thread src/test/fuzz/fuzz.cpp Outdated

maflcko reviewed Oct 7, 2019

View reviewed changes

Comment thread src/test/fuzz/block.cpp Outdated

Comment thread src/test/fuzz/block.cpp Outdated

practicalswift force-pushed the fuzzers-block branch from 05d1ec5 to 6cb9c96 Compare October 7, 2019 15:09

fanquake added the Tests label Oct 7, 2019

practicalswift force-pushed the fuzzers-block branch from cec65bb to 0efdeb6 Compare October 9, 2019 11:02

DrahtBot added the Needs rebase label Oct 10, 2019

practicalswift force-pushed the fuzzers-block branch from 0efdeb6 to 4dbd07b Compare October 10, 2019 14:29

DrahtBot removed the Needs rebase label Oct 10, 2019

maflcko added Waiting for author and removed Waiting for author labels Oct 12, 2019

This was referenced Oct 15, 2019

tests: Add descriptor Parse(...) fuzzing harness #17018

Merged

tests: Add fuzzing harnesses for functions parsing scripts, numbers, JSON and HD keypaths (bip32) #17050

Merged

practicalswift force-pushed the fuzzers-block branch from 4dbd07b to 381ed33 Compare October 16, 2019 20:44

DrahtBot added the Needs rebase label Oct 24, 2019

practicalswift force-pushed the fuzzers-block branch from 381ed33 to 67922dc Compare October 24, 2019 21:28

DrahtBot removed the Needs rebase label Oct 24, 2019

practicalswift force-pushed the fuzzers-block branch from 67922dc to 64eb9b6 Compare October 31, 2019 14:13

practicalswift mentioned this pull request Oct 31, 2019

Add fuzzing seeds to recently contributed fuzzing harnesses bitcoin-core/qa-assets#2

Closed

DrahtBot added the Needs rebase label Nov 5, 2019

practicalswift force-pushed the fuzzers-block branch from 64eb9b6 to 88915e0 Compare November 6, 2019 13:59

DrahtBot removed the Needs rebase label Nov 6, 2019

practicalswift force-pushed the fuzzers-block branch from 88915e0 to 4efa427 Compare December 6, 2019 09:09

DrahtBot added Needs rebase and removed Needs rebase labels Dec 6, 2019

practicalswift mentioned this pull request Dec 7, 2019

fuzzing: Write a fuzzer for structured data (e.g. libprotobuf-mutator) #17657

Closed

maflcko reviewed Dec 11, 2019

View reviewed changes

Comment thread src/test/fuzz/block.cpp Outdated

practicalswift force-pushed the fuzzers-block branch from 1647af9 to c5d08da Compare December 11, 2019 23:00

maflcko reviewed Dec 13, 2019

View reviewed changes

Comment thread src/test/fuzz/block.cpp Outdated

practicalswift force-pushed the fuzzers-block branch from c5d08da to dec2e98 Compare December 13, 2019 23:37

tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers …

ec8dcb0

…missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus

practicalswift force-pushed the fuzzers-block branch from dec2e98 to 230b692 Compare December 15, 2019 21:37

tests: Add fuzzing harness for CheckBlock(...) and other CBlock relat…

893aa20

…ed functions

practicalswift force-pushed the fuzzers-block branch from 230b692 to 893aa20 Compare December 15, 2019 21:39

maflcko merged commit 893aa20 into bitcoin:master Dec 16, 2019

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

practicalswift deleted the fuzzers-block branch April 10, 2021 19:39

PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Mar 29, 2022

Merge pull request #4710 from kittywhiskers/fuzzing_bps

bf458b1

merge bitcoin#17071...bitcoin#18206: fuzzing harness backports (part 1)

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

Navigation Menu

Uh oh!

tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions - #17071

tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions#17071
maflcko merged 2 commits into
bitcoin:masterfrom
practicalswift:fuzzers-block

practicalswift commented Oct 7, 2019 •

edited

Loading

Uh oh!

Uh oh!

maflcko left a comment

Uh oh!

Uh oh!

Uh oh!

DrahtBot commented Oct 7, 2019 •

edited

Loading

Uh oh!

practicalswift commented Oct 24, 2019

Uh oh!

practicalswift commented Oct 31, 2019

Uh oh!

practicalswift commented Oct 31, 2019 •

edited

Loading

Uh oh!

practicalswift commented Dec 6, 2019

Uh oh!

practicalswift commented Dec 10, 2019

Uh oh!

Uh oh!

maflcko commented Dec 13, 2019

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

practicalswift commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DrahtBot commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

practicalswift commented Oct 24, 2019

Uh oh!

practicalswift commented Oct 31, 2019

Uh oh!

practicalswift commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

practicalswift commented Dec 6, 2019

Uh oh!

practicalswift commented Dec 10, 2019

Uh oh!

Uh oh!

maflcko commented Dec 13, 2019

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

practicalswift commented Oct 7, 2019 •

edited

Loading

DrahtBot commented Oct 7, 2019 •

edited

Loading

practicalswift commented Oct 31, 2019 •

edited

Loading