Skip to content

test: Remove unused node from feature_nulldummy - #22150

Merged
maflcko merged 1 commit into
bitcoin:masterfrom
maflcko:2106-testFaster
Jun 5, 2021
Merged

test: Remove unused node from feature_nulldummy#22150
maflcko merged 1 commit into
bitcoin:masterfrom
maflcko:2106-testFaster

Conversation

@maflcko

@maflcko maflcko commented Jun 4, 2021

Copy link
Copy Markdown
Member

This is confusing and might even slow down the test.

This reverts a change that was added a year ago in d438d60 and then the need for it was removed by 95d5d5e six months ago.

@fanquake fanquake added the Tests label Jun 4, 2021
@DrahtBot

DrahtBot commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@jonatack jonatack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 346e52a this reverts a change that was added a year ago in d438d60 and then the need for it was removed by 95d5d5e six months ago

(perhaps add this context to the PR description)

@maflcko

maflcko commented Jun 5, 2021

Copy link
Copy Markdown
Member Author

Thanks for digging up the context! Added to description.

@maflcko
maflcko merged commit 898dd9e into bitcoin:master Jun 5, 2021
@maflcko
maflcko deleted the 2106-testFaster branch June 5, 2021 06:42
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants