guix: parallelize LIEF build - #25458
Merged
Merged
Conversation
Member
|
Concept ACK |
Contributor
Guix builds
|
Member
|
Not sure why this failed, maybe a cosmic ray? |
Contributor
|
Concept ACK, GUIX hashes: x86: arm64: |
Member
|
Build on x86_64, matches @jarolrod at least Code review ACK 8d25926 |
Member
I think so. I checked the |
Member
Guix builds on
|
Contributor
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 7, 2023
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jun 8, 2023
backport: merge bitcoin#18434, bitcoin#21664, bitcoin#20608, bitcoin#21871, bitcoin#21255, bitcoin#21428, bitcoin#21889, bitcoin#22070, bitcoin#22392, bitcoin#23535, bitcoin#23811, bitcoin#23838, bitcoin#23839, bitcoin#23148, bitcoin#20422, bitcoin#24561, bitcoin#26075, bitcoin#25458, partial bitcoin#22381 (guix backports: part 1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though it's (re)built infrequently, the LIEF build currently runs with a single job, and thus takes much longer to build than it should. This change modifies our packge so that the cmake invocation is done with multiple jobs, using
parallel-job-count. On a 6 core arm64 machine, this results in a ~80% speed up, and reduces the time taken to build the LIEF packge from ~19m to ~4m.Guix Build (x86_64):
Guix Build (arm64):