[Moveonly] Create ui_interface.cpp

[maflcko]

Should be trivial to review, since it's move only besides a missing return true;.

[paveljanik]

Concept ACK.

I think that the return true is to have the same prototypes of both Warning and Error functions. Is it worth it?

[maflcko]

Is it worth it?

No, InitError should fail and trigger a shutdown. InitWarning, however, should not trigger a shutdown and continue execution. Thus the return value is not only unused but also misleading.

[paveljanik]

@MarcoFalke Of course I agree with you :-)

[jonasschnelli]

Concept ACK.
Not sure if the function names should contain the Init* part (like InitError() and InitWarning()). From the ui_interface perspective, the error/warning is unrelated to the init process.

[maflcko]

the error/warning is unrelated to the init process.

This is a valid point, but I think there is no actual use case for a modal pop up other than in the init process. I'd rather keep the old name, and change it when there is a valid use case for a blocking dialog.

[laanwj]

Concept ACK

[maflcko]

Anything holding this back?

[laanwj]

Nit: the UI interface should be in bitcoin_server.a, not bitcoin_util.a. It should not be used by the other tools, just bitcoind and bitcoin-qt.

[maflcko]

Addressed nit