Bugfix: Allow building libbitcoinconsensus without any univalue - #8293
Merged
Merged
Conversation
Member
|
Concept ACK. A few nits:
|
Contributor
Author
|
It's conceivable that at some point bitcoin-tx could be freed of the univalue dependency as well, so I'm not sure it makes sense to do the dedicated var? |
Member
|
I don't think that's realistic. bitcoin-tx uses JSON objects in various places in the interface |
Member
|
@luke-jr My only concern is that "system_univalue" should not be equated to "don't use any univalue". renaming to need_univalue would suffice. |
Member
|
Ok, let's rename it then. |
luke-jr
force-pushed
the
sys_univalue_opt
branch
2 times, most recently
from
August 9, 2016 05:28
d0c8332 to
f22e2a3
Compare
Contributor
Author
|
Renamed. |
luke-jr
force-pushed
the
sys_univalue_opt
branch
from
August 9, 2016 05:31
f22e2a3 to
8a270b2
Compare
Member
|
Thanks. utACK. |
laanwj
added a commit
that referenced
this pull request
Aug 13, 2016
…nivalue 8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
Contributor
|
ut ACK |
Contributor
Author
|
Needs backport to 0.13. |
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 21, 2016
Github-Pull: bitcoin#8293 Rebased-From: 8a270b2
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 8, 2018
…t any univalue 8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…t any univalue 8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.