[bench] Avoid function call arguments which are pointers to uninitialized values - #9949
Merged
laanwj merged 1 commit intoApr 10, 2017
Conversation
laanwj
reviewed
Mar 8, 2017
Member
There was a problem hiding this comment.
A NUL terminator is unnecessary here, as the array is not interpreted as a string.
laanwj
reviewed
Mar 8, 2017
practicalswift
force-pushed
the
avoid-pointers-to-unitialized-values-in-function-calls
branch
from
March 8, 2017 15:40
4c5671f to
218d915
Compare
Contributor
Author
|
@laanwj Thanks for the quick review! This PR is now limited to fixing the two uninitialized values in |
Contributor
|
ACK 218d915 |
Member
|
Uninitialized values are fine if they are not read?
|
Contributor
|
@MarcoFalke it looks like these are read, however (well, copied and never acted on, but still technically undefined behavior). utACK 218d915 |
Contributor
Author
|
Adding link to "Always initialize an object" (ES.20) in the C++ Core Guidelines. |
laanwj
added a commit
that referenced
this pull request
Apr 10, 2017
… to uninitialized values 218d915 [bench] Avoid function call arguments which are pointers to uninitialized values (practicalswift) Tree-SHA512: 68d62e9442094f171433291b7f13dba20fc7ead5fd7f2292e1eb97ae51aa2345d40224c4a65c2e5d3552802b3cd0f675a82b6181cf5b77e964355650b25089f0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 20, 2019
…ointers to uninitialized values 218d915 [bench] Avoid function call arguments which are pointers to uninitialized values (practicalswift) Tree-SHA512: 68d62e9442094f171433291b7f13dba20fc7ead5fd7f2292e1eb97ae51aa2345d40224c4a65c2e5d3552802b3cd0f675a82b6181cf5b77e964355650b25089f0
markblundeberg
pushed a commit
to markblundeberg/bitcoin-abc
that referenced
this pull request
Jun 15, 2019
… to uninitialized values Summary: 218d915 [bench] Avoid function call arguments which are pointers to uninitialized values (practicalswift) Tree-SHA512: 68d62e9442094f171433291b7f13dba20fc7ead5fd7f2292e1eb97ae51aa2345d40224c4a65c2e5d3552802b3cd0f675a82b6181cf5b77e964355650b25089f0 Backport of Core PR9949 bitcoin/bitcoin#9949 Test Plan: make check Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3324
jtoomim
pushed a commit
to jtoomim/bitcoin-abc
that referenced
this pull request
Jun 29, 2019
… to uninitialized values Summary: 218d915 [bench] Avoid function call arguments which are pointers to uninitialized values (practicalswift) Tree-SHA512: 68d62e9442094f171433291b7f13dba20fc7ead5fd7f2292e1eb97ae51aa2345d40224c4a65c2e5d3552802b3cd0f675a82b6181cf5b77e964355650b25089f0 Backport of Core PR9949 bitcoin/bitcoin#9949 Test Plan: make check Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3324
jonspock
pushed a commit
to devaultcrypto/devault-legacy
that referenced
this pull request
Jul 5, 2019
… to uninitialized values Summary: 218d915 [bench] Avoid function call arguments which are pointers to uninitialized values (practicalswift) Tree-SHA512: 68d62e9442094f171433291b7f13dba20fc7ead5fd7f2292e1eb97ae51aa2345d40224c4a65c2e5d3552802b3cd0f675a82b6181cf5b77e964355650b25089f0 Backport of Core PR9949 bitcoin/bitcoin#9949 Test Plan: make check Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3324
jonspock
pushed a commit
to devaultcrypto/devault-legacy
that referenced
this pull request
Jul 9, 2019
… to uninitialized values Summary: 218d915 [bench] Avoid function call arguments which are pointers to uninitialized values (practicalswift) Tree-SHA512: 68d62e9442094f171433291b7f13dba20fc7ead5fd7f2292e1eb97ae51aa2345d40224c4a65c2e5d3552802b3cd0f675a82b6181cf5b77e964355650b25089f0 Backport of Core PR9949 bitcoin/bitcoin#9949 Test Plan: make check Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3324
practicalswift
deleted the
avoid-pointers-to-unitialized-values-in-function-calls
branch
April 10, 2021 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit: