Conversation
`--proxy` accepted proxy_opts for both electrum and esplora clients but did not use them during connection. This fix updates both clients to use the provided proxy options during connection - added test for connection through proxy - updated CHANGELOG
- The cbf arm of new_blockchain_client was ignored proxy_opts but bdk_kyoto 0.17.0 support a proxy. This change adds the connection through socks5 proxy. - add tests coverage for cbf connection through socks5 proxy
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 57.78% 59.24% +1.46%
==========================================
Files 22 23 +1
Lines 3733 3857 +124
==========================================
+ Hits 2157 2285 +128
+ Misses 1576 1572 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The application accepted SOCKS5 proxy options (--proxy, --proxy_auth, --retries, --timeout), persisted them to config.toml, and reloaded them on every subsequent run but never applied them to any blockchain client. This PR updates the proxy options for electrum, esplora and cbf.
Fixes #328
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: