Skip to content

fix(proxy):apply saved proxy config to electrum, esplora and cbf - #329

Open
tvpeter wants to merge 2 commits into
bitcoindevkit:masterfrom
tvpeter:fix/apply-proxy-config
Open

tvpeter wants to merge 2 commits into
bitcoindevkit:masterfrom
tvpeter:fix/apply-proxy-config

Conversation

@tvpeter

@tvpeter tvpeter commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Description

The application accepted SOCKS5 proxy options (--proxy, --proxy_auth, --retries, --timeout), persisted them to config.toml, and reloaded them on every subsequent run but never applied them to any blockchain client. This PR updates the proxy options for electrum, esplora and cbf.

Fixes #328

Notes to the reviewers

Changelog notice

  • Fixed routing electrum and esplora traffic through configured socks5 proxy
  • Routed compact filter (cbf) traffic through the configured SOCKS5 proxy
  • Rejected --proxy on the rpc backend, and unsupported proxy options (--proxy_auth, --timeout) on the rpc and cbf backends, instead of silently ignoring them

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

`--proxy` accepted proxy_opts for both electrum and esplora clients
but did not use them during connection. This fix updates both
clients to use the provided proxy options during connection
- added test for connection through proxy
- updated CHANGELOG
- The cbf arm of new_blockchain_client was ignored proxy_opts but
bdk_kyoto 0.17.0 support a proxy. This change adds the
connection through socks5 proxy.

- add tests coverage for cbf connection through socks5 proxy
@tvpeter tvpeter self-assigned this Sep 18, 2026
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.34884% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.24%. Comparing base (5afbc8a) to head (f519a04).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/client.rs 86.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   57.78%   59.24%   +1.46%     
==========================================
  Files          22       23       +1     
  Lines        3733     3857     +124     
==========================================
+ Hits         2157     2285     +128     
+ Misses       1576     1572       -4     
Flag Coverage Δ
rust 59.24% <95.34%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvpeter tvpeter changed the title Fix/apply proxy config Fix(proxy):apply saved proxy config to electrum, esplora and cbf Sep 21, 2026
@tvpeter tvpeter changed the title Fix(proxy):apply saved proxy config to electrum, esplora and cbf fix(proxy):apply saved proxy config to electrum, esplora and cbf Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

SOCKS5 proxy options are parsed, persisted, then silently ignored — wallet traffic goes direct despite --proxy

1 participant