Skip to content

Remove old env_logger and log dependencies - #336

Open
emma31-dev wants to merge 3 commits into
bitcoindevkit:masterfrom
emma31-dev:delete/old-env_logger-dependency
Open

emma31-dev wants to merge 3 commits into
bitcoindevkit:masterfrom
emma31-dev:delete/old-env_logger-dependency

Conversation

@emma31-dev

Copy link
Copy Markdown

Description

BDK-CLI has had env_logger for over 4 years and it served the project well but in recent time tracing came along because of payjoin and in is now used in many other areas of the codebase. env_logger with log is only used in main.rs and config.rs for just a single log. yet the package itself adds to binary size with little use now tracing handles the logs better.

Changelog notice

  • Dropped env-logger and log dependencies

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Replace log calls with tracing equivalents.

Signed-off-by: emma31-dev <emmanuelfidel07@gmail.com>
Signed-off-by: emma31-dev <emmanuelfidel07@gmail.com>
Signed-off-by: emma31-dev <emmanuelfidel07@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant