ci: remove slow and inefficient cargo caching - #2129
harrshita123 wants to merge 1 commit into
Conversation
|
maybe split this in two commits, once to remove cache and another to fix esplora, is better than leave all in once commit, and try use conventional commits to call more attention of maintainers to review your PR. Another thing, i dont know if this is must relevant to the project now, i think fix ci is important but maybe is better join this in a PR with more chores of BDK, look for CONTRIBUTING she say to try give more substance to the commits, again i think this CI fix matters, but i dont know if you got a review fast |
|
|
|
@harrshita123 needs rebase |
|
This pull request has had no activity for 180 days and has been labeled stale. If this work is still in progress or waiting on review, a comment or push will remove the label. PRs with no further activity for 30 days will be closed. |
Description
This PR disables Cargo caching in GitHub Actions as recommended in #1637. Compressing and uploading the cache was consistently taking longer than the actual builds, slowing down the feedback loop.
I've also included a fix for
bdk_esploracompilation failures. The build was breaking due to-D warningsand the deprecation ofget_blocksin the latestesplora-client. I've migrated the extensions to useget_block_infos.Notes to the reviewers
esplorafix was required to get CI passing, as the deprecation warnings were blocking the build..time.heightto.heightas per the newBlockInfostruct.Changelog notice
get_blockstoget_block_infosChecklists
All Submissions:
Bugfixes: