Skip to content

Fix bdk_esplora compilation error by bumping esplora_client version - #2136

Merged
evanlinjin merged 1 commit into
bitcoindevkit:masterfrom
evanlinjin:fix/esplora-compile
Mar 6, 2026
Merged

Fix bdk_esplora compilation error by bumping esplora_client version#2136
evanlinjin merged 1 commit into
bitcoindevkit:masterfrom
evanlinjin:fix/esplora-compile

Conversation

@evanlinjin

@evanlinjin evanlinjin commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

I didn't realize #2053 didn't actually compile when I merged it. This PR fixes this by bumping esplora_client to 0.12.3 so that the .get_block_infos method is always available.

Changelog

Fixed:
- Bump `esplora_client` to `0.12.3` so that the `.get_block_infos` method is always available.

Checklists

All Submissions:

@luisschwab

luisschwab commented Mar 5, 2026

Copy link
Copy Markdown
Member

What do you mean by didn't compile? #2130 fixed the deprecated warning by using get_block_infos, then #2053 rebased on top of it and was merged. This is effectively a reversal of #2130.

@evanlinjin

evanlinjin commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

What do you mean by didn't compile? #2130 fixed the deprecated warning by using get_block_infos, then #2053 rebased on top of it and was merged. This is effectively a reversal of #2130.

Okay I think I found the problem. I'm assuming get_block_infos was added in a minor release of esplora_client.

I never did cargo update so Cargo.lock was stuck in the past. A minimum version of esplora_client should be enforced though.

@evanlinjin evanlinjin closed this Mar 5, 2026
@evanlinjin
evanlinjin force-pushed the fix/esplora-compile branch from a4173ad to 91db0f2 Compare March 5, 2026 23:10
@github-project-automation github-project-automation Bot moved this to Done in BDK Chain Mar 5, 2026
@evanlinjin
fix(esplora): Bump esplora-client to 0.12.3
1804699 
This is required for `.get_block_infos` to be available.
@evanlinjin evanlinjin reopened this Mar 5, 2026
@luisschwab

luisschwab commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This is weird, because CI was complaining about using get_blocks. Perhaps we should only use MAJOR.MINOR or fix it on a patch version and bump manually.

@evanlinjin evanlinjin self-assigned this Mar 5, 2026
@evanlinjin evanlinjin added the bug Something isn't working label Mar 5, 2026
@oleonardolima

oleonardolima commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

This is weird, because CI was complaining about using get_blocks. Perhaps we should only use MAJOR.MINOR or fix it on a patch version and bump manually.

CI complained because it does not keep the Cargo.lock and always resolves to the latest compatible version.

oleonardolima
oleonardolima approved these changes Mar 6, 2026
View reviewed changes

@oleonardolima oleonardolima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1804699

Do mind to update the PR title/description before merging.

@luisschwab

luisschwab commented Mar 6, 2026

Copy link
Copy Markdown
Member

Perhaps we should do it like rust-bitcoin does it: https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools/tree/master/cargo-rbmt#lock-files

luisschwab
luisschwab approved these changes Mar 6, 2026
View reviewed changes

@luisschwab luisschwab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1804699

@evanlinjin evanlinjin changed the title fix(esplora): Compilation error Fix bdk_esplora compilation error Mar 6, 2026
@evanlinjin evanlinjin changed the title Fix bdk_esplora compilation error Fix bdk_esplora compilation error by bumping esplora_client version Mar 6, 2026
@evanlinjin
evanlinjin merged commit a6bfbd4 into bitcoindevkit:master Mar 6, 2026
32 checks passed
@evanlinjin evanlinjin mentioned this pull request Mar 11, 2026
Merged
1 task done
oleonardolima added a commit that referenced this pull request Mar 11, 2026
@oleonardolima
Merge #2148: chain 0.23.x: Fix panic in scan loop and update msrv a…
d8be40c 
…nd esplora-client

2ee48d7 fix(esplora): Bump `esplora-client` to `0.12.3` (志宇)
af6791f ci: Fix `ci/pin-msrv.sh` (志宇)
fb3e169 ci: Fix pin msrv for 1.75.0 (志宇)
8d2ca9b fix: remove panic from stop gap scan loop (Matthew)

Pull request description:

  ### Description

  Backport of #2053, #2136. Also fixes CI MSRV issues.

  Replaces #2147 - Purely MSRV fixes still resulted in CI failure due to clippy.
  Replaces #2141 - Might as well include the whole PR backport.

  ### Changelog notice

  ```md
  Fixed:
  - Avoid a panic in the Esplora stop‑gap scan loop by tracking consecutive unused scripts to compute the gap boundary.
  - Bump `esplora_client` to `0.12.3` so that the `.get_block_infos` method is always available.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  luisschwab:
    ACK 2ee48d7
  oleonardolima:
    ACK 2ee48d7

Tree-SHA512: 0f183e2b5ffc6629298f960f22e95020df58da98171c69e880afab5d57f337af240ff7ad97244f3f052d3b1a3fdd8a91543b5a943eeac2234de02672fc94d3f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes
@luisschwab luisschwab luisschwab approved these changes

Assignees

@evanlinjin evanlinjin

Labels

bug Something isn't working

Projects

BDK Chain
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evanlinjin @luisschwab @oleonardolima