Skip to content

Added Jupyter Chapter 1.1 (Schnorr Introduction). - #2

Closed
jachiang wants to merge 0 commit into
bitcoinops:masterfrom
jachiang:master
Closed

Added Jupyter Chapter 1.1 (Schnorr Introduction).#2
jachiang wants to merge 0 commit into
bitcoinops:masterfrom
jachiang:master

Conversation

@jachiang

Copy link
Copy Markdown
Contributor

This is the first workshop chapter after an initial setup chapter (chaper 1.0).

An overview of the planned workshop chapters can be found here.

@jachiang
jachiang force-pushed the master branch 2 times, most recently from d524c1e to 335b05b Compare August 27, 2019 22:22
@jachiang

Copy link
Copy Markdown
Contributor Author

Ping @elichai for chapter review.

@jachiang
jachiang requested a review from elichai August 30, 2019 14:03
@jachiang
jachiang force-pushed the master branch 2 times, most recently from 63acfc9 to 3edbb8c Compare September 2, 2019 11:43
@jachiang

jachiang commented Sep 2, 2019

Copy link
Copy Markdown
Contributor Author

Update: Imports util.py

Comment thread 1.1-Introduction-to-Schnorr.ipynb Outdated
Comment thread 1.1-Introduction-to-Schnorr.ipynb Outdated
Comment thread 1.1-Introduction-to-Schnorr.ipynb Outdated
Comment thread 1.1-Introduction-to-Schnorr.ipynb Outdated
Comment thread 1.1-Introduction-to-Schnorr.ipynb Outdated
Comment thread 1.1-Introduction-to-Schnorr.ipynb Outdated
Comment thread 1.1-Introduction-to-Schnorr.ipynb Outdated
Comment thread Solutions/1.1-Introduction-to-Schnorr-Solutions.ipynb Outdated
Comment thread Solutions/1.1-Introduction-to-Schnorr-Solutions.ipynb Outdated
Comment thread Solutions/1.1-Introduction-to-Schnorr-Solutions.ipynb Outdated
@elichai

elichai commented Sep 2, 2019

Copy link
Copy Markdown
Collaborator

First of all wow. you did a lot of work 👍

Second, I hope we can try to simplify some of this. It's going to be pretty hard to get into the details you're getting even into more details and without confusing, the difference between a group order and field order for example is pretty confusing without trying to explain more theoretical parts.

Another thing is quadratic residue.
We are testing a quad residue over y^2=x^3+7 so the quad residue is on y over the field order p.
so either quadratic residue in the curve equation. or just quadratic residue mod p or even just quadratic residue.

@jachiang

jachiang commented Sep 3, 2019

Copy link
Copy Markdown
Contributor Author

I have now updated this PR and split out the EC-math section to chapter 0.2 (EC math review), as discussed in our call previously.

@elichai Many thanks for your review. Your corrections have been incorporated, with one exception.

@bitschmidty Appreciate your critical review of this chapter and 0.2 ec math review.

@jnewbery

jnewbery commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

rebased on master

@jnewbery

jnewbery commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

@elichai - thanks for reviewing! I like your suggestions about making ECKey and ECPubKey easier to deal with. Are you able to make a PR to do that? We can add new methods to ECKey and ECPubKey in util.py and then import from there.

@jachiang

Copy link
Copy Markdown
Contributor Author

Updated with input from feedback. Incorporates add/mul key class methods in code solutions.

@jnewbery

Copy link
Copy Markdown
Contributor

I think all feedback in this PR is addressed in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants