Added Jupyter Chapter 1.1 (Schnorr Introduction). - #2
Conversation
d524c1e to
335b05b
Compare
|
Ping @elichai for chapter review. |
63acfc9 to
3edbb8c
Compare
|
Update: Imports util.py |
|
First of all wow. you did a lot of work 👍 Second, I hope we can try to simplify some of this. It's going to be pretty hard to get into the details you're getting even into more details and without confusing, the difference between a group order and field order for example is pretty confusing without trying to explain more theoretical parts. Another thing is quadratic residue. |
|
I have now updated this PR and split out the EC-math section to chapter 0.2 (EC math review), as discussed in our call previously. @elichai Many thanks for your review. Your corrections have been incorporated, with one exception. @bitschmidty Appreciate your critical review of this chapter and 0.2 ec math review. |
|
rebased on master |
|
@elichai - thanks for reviewing! I like your suggestions about making ECKey and ECPubKey easier to deal with. Are you able to make a PR to do that? We can add new methods to ECKey and ECPubKey in util.py and then import from there. |
|
Updated with input from feedback. Incorporates add/mul key class methods in code solutions. |
|
I think all feedback in this PR is addressed in #26 |
This is the first workshop chapter after an initial setup chapter (chaper 1.0).
An overview of the planned workshop chapters can be found here.