0. Toolchain Setup - #7
Conversation
jachiang
left a comment
There was a problem hiding this comment.
Looks good! Many thanks for merging setup documents and making the on-boarding process much better. I am trying to get resolution on the TestWrapper PR soon, so it can be adopted here as well.
| } | ||
| ], | ||
| "source": [ | ||
| "import setup" |
There was a problem hiding this comment.
Update to import util when TestWrapper PR is resolved.
There was a problem hiding this comment.
Done. I've rebased this PR on the TestWrapper changes.
| } | ||
| ], | ||
| "source": [ | ||
| "from test_framework.test_wrapper import TestWrapper\n", |
There was a problem hiding this comment.
If using util.py, this import can be removed.
There was a problem hiding this comment.
Done. I've rebased this PR on the TestWrapper changes.
2316e0a to
24446a6
Compare
| branch, v0.1](https://github.com/bitcoinops/bitcoin/releases/tag/v0.1) which | ||
| supports schnorr and taproot. | ||
|
|
||
|  |
There was a problem hiding this comment.
See comment: #5 (comment)
- I think the 'imports' arrow is going the wrong way. Either change the text to 'imported by' or reverse the arrow.
- s/1.0-Workshop-Setup.iypnb/1.0-Workshop-Setup.ipynb/
| "* Separate test wrapper `setup`, `shutdown` and your code into different cells. This ensures that an error in your code does not affect the test wrapper object and prevents orphaned subprocesses.\n", | ||
| "* Only run one test wrapper object at a time.\n", | ||
| "* If the subprocesses do become orphaned somehow, you can run the following:\n", | ||
| " * `ps -ax | grep bitcoind` to see outstanding bitcoind processes.\n", |
There was a problem hiding this comment.
Do we also need instructions for windows users here?
24446a6 to
91e8972
Compare
|
I've rebased on master and pushed a commit with a bunch of minor nits. I'm going to merge this now. Any further feedback can be addressed in follow-up PRs. |
Combined James and Johns PRs to start.
Work in progress, more to come.