Added Jupyter Chapter 2.1 (Segwit v1 outputs) - #9
Merged
Conversation
Contributor
|
rebased on master |
Contributor
Author
|
Updated for this branch. |
Contributor
|
rebased on master |
Contributor
|
pushed a commit addressing some nits |
Collaborator
|
Need to update assertions over the version. |
Collaborator
|
What do you think about using |
elichai
approved these changes
Sep 18, 2019
elichai
self-requested a review
September 18, 2019 12:05
elichai
requested changes
Sep 18, 2019
elichai
left a comment
Collaborator
There was a problem hiding this comment.
Some nits. everything looks great except that the answers don't work for me.
It all works fine until:
# Construct transaction witness
witness = CScriptWitness()
witness.stack.append(sig_agg)
witness_in = CTxInWitness()
witness_in.scriptWitness = witness
spending_tx.wit.vtxinwit.append(witness_in)
# Serialize Schnorr transaction for broadcast
spending_tx_str = spending_tx.serialize().hex()
# Test mempool acceptance
print(test.nodes[0].testmempoolaccept([spending_tx_str]))
Which gives me:
[{'txid': '3ec5138e77b3a9d179adf65084ba57742521f45b22c30cc56cb3f132e88dd6c4', 'allowed': False, 'reject-reason': '64: non-mandatory-script-verify-flag (Invalid signature for taproot key path spending)'}]
bitschmidty
reviewed
Sep 18, 2019
bitschmidty
reviewed
Sep 20, 2019
jnewbery
reviewed
Sep 21, 2019
- add more introduction - remove Part B from the exercise - much more
Contributor
|
All review comments addressed. Time to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of the workshop after the Schnorr chapters, and also the first chapter where participants begin to construct transactions (for broadcast).