Add global search palette and dev reload shortcut - #125
Merged
Merged
Conversation
added 3 commits
September 22, 2026 07:38
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
wesbillman
marked this pull request as ready for review
September 22, 2026 14:20
added 4 commits
September 22, 2026 08:30
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Collaborator
Author
Screen.Recording.2026-09-22.at.9.50.37.AM.mov |
added 3 commits
September 22, 2026 09:55
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented by Brain on behalf of Wes.
Delivered scope
Wes explicitly approved the wider global/public-search behavior and FOUNDATION session integration in the originating discussion. Latest pushed branch head:
16fafe999da2391c770995e6c148e4a4dd066f96(remote ref verified). No app restarted or new native server launched.Validation and review — current head 16fafe9
app-style-order,emoji,reactions,typeahead,unread,thread-unread,live-status,global-search,message-navigation,gifsandproduct-uifiles, Chromium and WebKit, two workers, no retries (~150 seconds locally). Source/test diff hash before commit:895f5d702f1225e68b23b51b6aa3b9667da4d74ea61509989835562c418fd6cc. The staged hook subsequently only reflowed one live-status selector; the entire six-case live-status file passed again at committed 16fafe9. All other browser-tested source/test bytes are unchanged.Latest CI cause and repair
Failing run 35750742940 checked 588c81e merged with main e9717dd. JavaScript, Rust/tool integration and browser measurements passed; all four functional browser shards failed (14 cases per engine). These were not the old search-label failure:
ChannelsPagenow waits while the initial list is idle/loading before resolving an omitted target. Existing unread/reload assertions remain; add an explicit no-premature-exact-roster assertion. Production repair: 6 added / 1 removed lines, including comments; no timers, retry policy or authority changes.Reproduction: the original disabled-composer, reaction and warning failures reproduced in both local engines; unread mock failure also reproduced locally. The first repaired-fixture run was 108 pass / 2 fail, exposing the thread reload regression in both engines. The sequencing guard then passed the complete 20-case unread/thread-unread/search group; the final expanded run passed all 110. No timeouts relaxed, assertions removed, retries enabled or error allowlists broadened.
Process miss: previous validation covered search/navigation but not every consumer of the new shared membership gate. The older “Find a page” fix in 588c81e repaired one incoming-main selector, not these later failures. Contribution guidance now explicitly includes standalone composer/reaction fixtures, broker query contracts and complete restored-navigation/unread journeys when access gating changes; early mock failures can mask later product regressions.
Browser coverage accounting
Three original added scenarios (six engine cases), no scenario deletions: photo-avatar geometry, portal/keyboard focus/navigation, public nonmember exact-result opening. This follow-up adds zero scenarios, strengthens the existing reload assertion and upgrades public search to the production-broker lane. Browser justification remains real focus/layout and app/broker wiring; authority matrices remain in lower-layer tests. Warm local 110-case runs took ~144 seconds before the sequencing repair (108 pass/2 fail) and ~150 seconds afterward (110 pass); mixed outcome/cache/load means this is not an isolated performance comparison or hosted CI cost claim.
Limits and remaining checks
Ready to review, not certified merge-ready. Hosted CI is pending. Please try native Cmd+K →
wes-crew→ select a message/reply and confirm exact landing. The live human-identity journey and native cold/warm latency remain unverified; production broker with modeled upstream is not live relay/native evidence. Native IME/correction beyond confirmed arrows, visual mode/size sweep, and dev-reload/production-absence checks remain deferred. No running app was restarted for this fix.Current community only; eight conversation matches and twenty message hits. No legacy forum kinds, search operators, people/agent DM creation, or deep-link/transport rewrite. Snippets reflect indexed content; opening resolves current content/deletion through the existing reader.
Scope accounting: before this CI repair the complete feature was 1,084 production insertions / 205 deletions across 20 source files; this adds 6/1 in ChannelsPage (tests/docs separate). The wider global/public-authority slice exceeded the original estimate, principally for access loss, read/write separation and recovery, not extra search features.