fix(channels): give floating unread cue an opaque panel surface - #153
Merged
Merged
Conversation
The sidebar's "Unread above/below" pill floats over the scrolled channel list, but since it adopted the shared outline Button its background has been transparent, so channel names showed through the control. Fill the floating wrapper with the sidebar's panel surface, round it to the pill radius, and restore a light shadow so the cue reads as lifted over the roster. The wrapper uses display: grid so it stays flush with the control and no fill shows around the pill. The button itself is untouched, so its background-color/color transition list is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
wesbillman
reviewed
Sep 23, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No blocking findings at 443f672ef121aabcb2c9b32aebee42b047649bb4 against base 877ae2a6749221dd6850d5695b5c8de023a239e3. The wrapper supplies an opaque light/dark panel surface and matching pill geometry without overriding the shared Button’s states, transitions, or unread-reveal behavior.
Exact-head CI passed; Windows native validation was skipped. Review was source-only: no builds or tests run, and live rendering, enlarged-text geometry, and native appearance remain unverified. The existing sidebar journey covers interaction/focus and transition behavior, but does not directly assert the new wrapper’s opacity.
wesbillman
approved these changes
Sep 23, 2026
zrmarley
added a commit
that referenced
this pull request
Sep 23, 2026
…search-send * origin/main: Connect attachments to existing message delivery (#176) perf: preserve unchanged thread row identities (#171) perf: cache markdown preparation by content (#172) Add safe attachment upload groundwork (#150) feat: add sampling profiler launch modes (#148) feat(channels): remove DMs from the sidebar (#157) Distinguish namesake agents and selected recipients (#142) feat(channels): move diagnostics into Channel Settings (#163) Replace warning banners with shared Base UI toasts (#164) feat(shortcuts): add keyboard shortcut settings (#155) fix(channels): give floating unread cue an opaque panel surface (#153) feat(communities): add BUZZ_DEV_OPEN_RELAY to open the default relay on fresh dev ports (#151) Restore recipient avatars beside the composer mention tool (#162) Fix startup inventory duplication and late panel scroll shifts (#160) feat(channels): add channel creation (#138) Standardize Button and IconButton with Buzz design tokens (#145) Signed-off-by: Zach Marley <zmarley@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar's "Unread above/below" pill floats over the scrolled channel list, but since it adopted the shared outline Button its background has been transparent, so channel names showed through the control.
Before
After
Changes
.unreadEdgewrapper with the sidebar's panel surface, round it to the pill radius, and restore--shadow-smso the cue reads as lifted over the roster.display: gridso it stays flush with the control and no sliver of fill shows around the pill.The button itself is untouched, so its
background-color/colortransition list is unchanged.🤖 Generated with Claude Code