ci: scope profile agent-identity read count to kind 0 reads - #243
Closed
kalvinnchau wants to merge 1 commit into
Closed
kalvinnchau wants to merge 1 commit into
kalvinnchau wants to merge 1 commit into
Conversation
The no-agent-hint case asserted the panel issued exactly one relay read in total, but ProfilePanel also reads its own self-published status (kind 30315, feature #219) for every target. That assertion was born failing: the CI run for #232 was cancelled before Vitest executed. Count only kind 0 profile reads, which are the reads this contract owns. Signed-off-by: Kalvin Chau <kalvin@block.xyz>
kalvinnchau
requested review from
a team,
comp615 and
wesbillman
as code owners
September 24, 2026 21:45
wesbillman
approved these changes
Sep 24, 2026
Contributor
Author
|
Closing: main already fixed this in #234 (same scoping via the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main was red:
ProfileAgentIdentity.test.tsx > adds no agent section or reads for a profile without an agent hintexpected the panel's relayquerymock to be called once, but got twice.ProfilePanelalso issues its own kind 30315 status read (pre-existing, #219) for every target, so counting all reads can never be 1. The assertion now counts only kind 0 profile reads — the reads this contract owns.