Repository navigation
feat: open exact agent instances from profiles - #251
Conversation
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
One P2 blocker: mounted profile rows do not recover archive labels after a same-session live-transport disconnect. Details and the minimal fix are inline; restore lazy archive demand after reset and cover that transition deterministically.
Source-only review traced exact native selection/action routing, signed-owner admission/revocation, same-head retention, viewer/community boundaries and panel lifecycle. Existing CI 36093076449 passed for this head integrated with base df7b7e7f45739f3e06e12d81623385701acdc51d: 3,712 Vitest tests and 662 browser journeys. Windows native validation was skipped. No PR code was executed for this review; native IPC/process execution, durable restoration and live archive acceptance remain unverified.
| const hasInstances = !!communityOrigin && matches.length > 0; | ||
| useEffect(() => { | ||
| if (hasInstances) void session.archives.ensure(); | ||
| }, [session, hasInstances]); |
There was a problem hiding this comment.
[P2] Re-demand archive evidence when the mounted session resets it
With this profile left open, a live transport disconnect calls archives.clear() (session.ts:1799-1810), publishing an empty idle snapshot. The relay service/session, native matches and hasInstances stay unchanged, so this effect does not rerun. Reconnect refreshes observed profiles but does not refresh archives: an archived row therefore loses its Archived label and stays unlabeled until the panel remounts or another archive consumer happens to load it.
Include archives.status in the effect dependencies and ensure when matching instances exist and that status is idle, as the existing template consumer does. Add a mounted-row regression that starts with ready archived evidence, drives it to idle without changing session/native matches, observes the new read, and verifies the label returns. This is a missing lazy-demand transition, not a request for polling or live archive subscription.
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Source review clear. The prior archive-reset blocker is fixed at e892e7395c8f28ac1b9e1a0e0a7d97e4f34fecda. Mounted rows now re-demand archives when the shared snapshot returns to idle. The deterministic component regression preserves the same native matches, verifies the new demand and restored Archived label, and checks no repeated demand through loading/ready. Existing assertions are preserved; no new blocker found in the two-file change since 1e7cc8a2.
Exact-head CI passed against base df7b7e7f45739f3e06e12d81623385701acdc51d: 3,713 Vitest tests and 662 browser journeys. Windows native validation was skipped. This was source-only review with no PR execution or reruns; the new test simulates the archive-store transition, not a live reconnect. Native IPC/process execution, durable restoration and live archive acceptance remain unverified.
Non-blocking existing limitation: if the archive read fails, this profile has no archive-retry control; its label remains absent until another archive consumer refreshes. An explicit retry is a separate follow-up, not a new condition on the agreed idle-demand repair. This is a follow-up comment, not approval.
Change
Verification