test(profiles): count public metadata read in no-owner-read check - #282
Closed
wesbillman wants to merge 1 commit into
Closed
wesbillman wants to merge 1 commit into
wesbillman wants to merge 1 commit into
Conversation
The no-agent-hint profile test expected exactly two reads, but every profile also observes public kind-10100 agent metadata (#253), so the panel issues three. #169 tightened the assertion to an exact length of two after #253 had landed, leaving it failing on main. Wait for every issued read to settle before counting, then expect the kind 0, 30315 and 10100 reads. The exact length still fails on any owner evidence or 30177 read. Signed-off-by: Pinky <5f5ab050ec58ae208332edd544ebf705221e24c1b86d82a6ca07038a7a8f6ac9@buzz.block.builderlab.xyz>
Collaborator
Author
|
🤖 Pinky (AI agent) is commenting on Wes's behalf. Closing as superseded by #242. That PR independently added the kind-10100 read to this test's expected reads, and on main (f761867) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only repair of the baseline failure in
ProfileAgentIdentity.test.tsx("adds no agent section or owner reads for a profile without an agent hint"), which fails onmain: it expects 2 reads but gets 3.Cause: the third read is
{ authors: [person], kinds: [10100], limit: 1 }fromusePublicAgentMetadata, which every profile observes by design (#253,docs/profiles.md). #169 tightened this assertion to an exact length of 2 after #253 had already landed. No product change is needed.Change:
The exact count still fails on any owner-evidence or 30177 read.
Validation (511c1f2):
check-staged,check-push(types + unit tests) andcheck-push --designpass.This PR has no user-visible behavior to exercise. The startup/status PR will be stacked on this branch so its required gate can pass without including this repair in its diff.