test(agents): Match native delete failure guidance - #299
Conversation
Signed-off-by: OpenAI Codex <codex@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78dfa24fdc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -453,9 +453,10 @@ it("a failed native delete after confirmed relay effects reports it and stays op | |||
| "Synthetic native refusal", | |||
| ); | |||
| await confirmDelete(userEvent.setup()); | |||
There was a problem hiding this comment.
Commit 700596d334d393fc1b00ea5db0442fdea0664f0c has no Signed-off-by trailer, so it violates the repository's per-commit DCO requirement and will not satisfy the hosted DCO check. Recreate this commit with git commit --signoff using the verified effective author identity before submitting it.
AGENTS.md reference: AGENTS.md:L151-L161
Useful? React with 👍 / 👎.
Why
After #283 changed the native operation error,
ProfileAgentArchive.test.tsxstill expected the old delete message. This makes the JavaScript CI job fail on currentmainand on PR #272's updated base.What
How
The test accepts either place the same error appears in the profile, without depending on the number of alerts.
Risk
Test-only change. Production behavior is unchanged.
Testing
No manual testing; the test uses a synthetic native refusal.
Bigger picture
This restores the baseline JavaScript gate needed to merge #272 and then #277. The test failed before this change and passed afterward on current
main.Generated with Codex